From: Xu Wang <cngesaint@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com,
wdongxu@linux.vnet.ibm.com, Xu Wang <cngesaint@gmail.com>,
xiawenc@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH V3 6/7] block: Add backing file loop check in qcow2_change_backing_file()
Date: Mon, 15 Jul 2013 05:42:35 -0400 [thread overview]
Message-ID: <1373881356-3294-7-git-send-email-cngesaint@gmail.com> (raw)
In-Reply-To: <1373881356-3294-1-git-send-email-cngesaint@gmail.com>
Add backing file loop check before execute change backing file for
qcow2 format.
Signed-off-by: Xu Wang <cngesaint@gmail.com>
---
block/qcow2.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index 0eceefe..01bd7d5 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1195,6 +1195,12 @@ fail:
static int qcow2_change_backing_file(BlockDriverState *bs,
const char *backing_file, const char *backing_fmt)
{
+ /* Check if loop exists in backing files chain after changed */
+ if (bdrv_backing_file_loop_check(bs->filename,
+ bs->drv ? bs->drv->format_name : NULL,
+ backing_file, backing_fmt)) {
+ return -EIO;
+ }
pstrcpy(bs->backing_file, sizeof(bs->backing_file), backing_file ?: "");
pstrcpy(bs->backing_format, sizeof(bs->backing_format), backing_fmt ?: "");
--
1.8.1.4
next prev parent reply other threads:[~2013-07-15 9:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 9:42 [Qemu-devel] [PATCH V3 0/7] Redefine and export backing file loop check Xu Wang
2013-07-15 9:42 ` [Qemu-devel] [PATCH V3 1/7] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list() Xu Wang
2013-07-18 5:11 ` Fam Zheng
2013-07-15 9:42 ` [Qemu-devel] [PATCH V3 2/7] block: Add WIN32 platform support for backing_file_loop_check() Xu Wang
2013-07-18 5:24 ` Fam Zheng
2013-07-15 9:42 ` [Qemu-devel] [PATCH V3 3/7] block: Check infinite loop in bdrv_img_create() Xu Wang
2013-07-15 9:42 ` [Qemu-devel] [PATCH V3 4/7] block: Add backing file loop check in change_backing_file() Xu Wang
2013-07-15 9:42 ` [Qemu-devel] [PATCH V3 5/7] block: Add infinite loop check in drive_init() Xu Wang
2013-07-18 5:27 ` Fam Zheng
2013-07-15 9:42 ` Xu Wang [this message]
2013-07-18 5:32 ` [Qemu-devel] [PATCH V3 6/7] block: Add backing file loop check in qcow2_change_backing_file() Fam Zheng
2013-07-15 9:42 ` [Qemu-devel] [PATCH V3 7/7] block: Add backing file loop check in qed_change_backing_file() Xu Wang
2013-07-18 4:56 ` [Qemu-devel] [PATCH V3 0/7] Redefine and export backing file loop check Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373881356-3294-7-git-send-email-cngesaint@gmail.com \
--to=cngesaint@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=wdongxu@linux.vnet.ibm.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).