From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyfJo-0000Rd-0H for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyfJj-0002wi-Vo for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:43 -0400 Received: from mail-pb0-x229.google.com ([2607:f8b0:400e:c01::229]:63707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyfJj-0002wV-OF for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:39 -0400 Received: by mail-pb0-f41.google.com with SMTP id rp16so11129942pbb.14 for ; Mon, 15 Jul 2013 02:43:39 -0700 (PDT) From: Xu Wang Date: Mon, 15 Jul 2013 05:42:36 -0400 Message-Id: <1373881356-3294-8-git-send-email-cngesaint@gmail.com> In-Reply-To: <1373881356-3294-1-git-send-email-cngesaint@gmail.com> References: <1373881356-3294-1-git-send-email-cngesaint@gmail.com> Subject: [Qemu-devel] [PATCH V3 7/7] block: Add backing file loop check in qed_change_backing_file() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, wdongxu@linux.vnet.ibm.com, Xu Wang , xiawenc@linux.vnet.ibm.com Add backing file loop check before execute change backing file for qed format. Signed-off-by: Xu Wang --- block/qed.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/block/qed.c b/block/qed.c index f767b05..79c2875 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1468,6 +1468,13 @@ static int bdrv_qed_change_backing_file(BlockDriverState *bs, return -ENOTSUP; } + /* Check if loop exists in backing files chain after changed */ + if (bdrv_backing_file_loop_check(bs->filename, + bs->drv ? bs->drv->format_name : NULL, + backing_file, backing_fmt)) { + return -EIO; + } + memcpy(&new_header, &s->header, sizeof(new_header)); new_header.features &= ~(QED_F_BACKING_FILE | -- 1.8.1.4