qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Vadim Rozenfeld" <vrozenfe@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 11/20] target-i386: cpu: convert 'model' to static property
Date: Tue, 16 Jul 2013 00:26:04 +0200	[thread overview]
Message-ID: <1373927181-24247-12-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1373927181-24247-1-git-send-email-imammedo@redhat.com>

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
v2:
  - afaerber: inline property definition inside of
              property array.
---
 target-i386/cpu.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 68b7694..4b8bcf1 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1231,6 +1231,12 @@ static void x86_cpuid_version_set_model(Object *obj, Visitor *v, void *opaque,
     env->cpuid_version |= ((value & 0xf) << 4) | ((value >> 4) << 16);
 }
 
+static PropertyInfo qdev_prop_model = {
+    .name  = "uint32",
+    .get   = x86_cpuid_version_get_model,
+    .set   = x86_cpuid_version_set_model,
+};
+
 static void x86_cpuid_version_get_stepping(Object *obj, Visitor *v,
                                            void *opaque, const char *name,
                                            Error **errp)
@@ -1491,6 +1497,7 @@ static Property cpu_x86_properties[] = {
     DEFINE_PROP_UINT32("level", X86CPU, env.cpuid_level, 0),
     DEFINE_PROP_UINT32("xlevel", X86CPU, env.cpuid_xlevel, 0),
     { .name = "family", .info = &qdev_prop_family },
+    { .name = "model", .info = &qdev_prop_model },
     DEFINE_PROP_END_OF_LIST(),
 };
 
@@ -2451,9 +2458,6 @@ static void x86_cpu_initfn(Object *obj)
     cs->env_ptr = env;
     cpu_exec_init(env);
 
-    object_property_add(obj, "model", "int",
-                        x86_cpuid_version_get_model,
-                        x86_cpuid_version_set_model, NULL, NULL, NULL);
     object_property_add(obj, "stepping", "int",
                         x86_cpuid_version_get_stepping,
                         x86_cpuid_version_set_stepping, NULL, NULL, NULL);
-- 
1.8.3.1

  parent reply	other threads:[~2013-07-15 22:26 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15 22:25 [Qemu-devel] [PATCH qom-cpu 00/21 v9] target-i386: convert CPU features into properties Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 01/20] target-i386: Move hyperv_* static globals to X86CPU Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 02/20] target-i386: convert 'hv_spinlocks' to static property Igor Mammedov
2013-11-27 17:55   ` Andreas Färber
2013-11-27 18:05     ` Paolo Bonzini
2013-11-27 18:21     ` Igor Mammedov
2013-11-27 21:21     ` Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 03/20] target-i386: convert 'hv_relaxed' " Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 04/20] target-i386: convert 'hv_vapic' " Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 05/20] target-i386: convert 'check' and 'enforce' to static properties Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 06/20] target-i386: cleanup 'foo' feature handling' Igor Mammedov
2013-12-16 16:51   ` Eric Blake
2013-12-19 16:32     ` Andreas Färber
2013-07-15 22:26 ` [Qemu-devel] [PATCH 07/20] target-i386: cleanup 'foo=val' feature handling Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 08/20] target-i386: cpu: convert 'level' to static property Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 09/20] target-i386: cpu: convert 'xlevel' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 10/20] target-i386: cpu: convert 'family' " Igor Mammedov
2013-07-15 22:26 ` Igor Mammedov [this message]
2013-07-15 22:26 ` [Qemu-devel] [PATCH 12/20] target-i386: cpu: convert 'stepping' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 13/20] target-i386: cpu: convert 'vendor' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 14/20] target-i386: cpu: convert 'model-id' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 15/20] target-i386: cpu: convert 'tsc-frequency' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 15/21] target-i386: cpu: substitute '_' with '-' for +-foo feature bits as well Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 16/21] target-i386: cpu: convert 'tsc-frequency' to static property Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 16/20] target-i386: set [+-]feature using static properties Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 17/20] qdev: introduce QDEV_FIND_PROP_FROM_BIT and qdev_prop_find_bit() Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 17/20] qdev: introduce qdev_prop_find_bit() Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 17/21] target-i386: set [+-]feature using static properties Igor Mammedov
2013-10-15 16:22   ` Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 18/21] qdev: introduce QDEV_FIND_PROP_FROM_BIT and qdev_prop_find_bit() Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 18/20] target-i386: use static properties in check_features_against_host() to print CPUID feature names Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 19/21] " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 19/20] target-i386: use static properties to list CPUID features Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 20/20] target-i386: remove unused *_feature_name arrays Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 20/21] target-i386: use static properties to list CPUID features Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 21/21] target-i386: remove unused *_feature_name arrays Igor Mammedov
2013-10-14 12:09 ` [Qemu-devel] [PATCH qom-cpu 00/21 v9] target-i386: convert CPU features into properties Igor Mammedov
2013-10-14 18:05   ` Andreas Färber
2013-10-15 12:27   ` Vadim Rozenfeld
2013-11-25 16:56 ` Igor Mammedov
2013-12-15 21:48 ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373927181-24247-12-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vrozenfe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).