qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Vadim Rozenfeld" <vrozenfe@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 21/21] target-i386: remove unused *_feature_name arrays
Date: Tue, 16 Jul 2013 00:26:21 +0200	[thread overview]
Message-ID: <1373927181-24247-29-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1373927181-24247-1-git-send-email-imammedo@redhat.com>

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 target-i386/cpu.c | 99 -------------------------------------------------------
 1 file changed, 99 deletions(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index f01e496..43fc1c7 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -60,98 +60,7 @@ static void x86_cpu_vendor_words2str(char *dst, uint32_t vendor1,
     dst[CPUID_VENDOR_SZ] = '\0';
 }
 
-/* feature flags taken from "Intel Processor Identification and the CPUID
- * Instruction" and AMD's "CPUID Specification".  In cases of disagreement
- * between feature naming conventions, aliases may be added.
- */
-static const char *feature_name[] = {
-    "fpu", "vme", "de", "pse",
-    "tsc", "msr", "pae", "mce",
-    "cx8", "apic", NULL, "sep",
-    "mtrr", "pge", "mca", "cmov",
-    "pat", "pse36", "pn" /* Intel psn */, "clflush" /* Intel clfsh */,
-    NULL, "ds" /* Intel dts */, "acpi", "mmx",
-    "fxsr", "sse", "sse2", "ss",
-    "ht" /* Intel htt */, "tm", "ia64", "pbe",
-};
-static const char *ext_feature_name[] = {
-    "pni|sse3" /* Intel,AMD sse3 */, "pclmulqdq|pclmuldq", "dtes64", "monitor",
-    "ds_cpl", "vmx", "smx", "est",
-    "tm2", "ssse3", "cid", NULL,
-    "fma", "cx16", "xtpr", "pdcm",
-    NULL, "pcid", "dca", "sse4.1|sse4_1",
-    "sse4.2|sse4_2", "x2apic", "movbe", "popcnt",
-    "tsc-deadline", "aes", "xsave", "osxsave",
-    "avx", "f16c", "rdrand", "hypervisor",
-};
-/* Feature names that are already defined on feature_name[] but are set on
- * CPUID[8000_0001].EDX on AMD CPUs don't have their names on
- * ext2_feature_name[]. They are copied automatically to cpuid_ext2_features
- * if and only if CPU vendor is AMD.
- */
-static const char *ext2_feature_name[] = {
-    NULL /* fpu */, NULL /* vme */, NULL /* de */, NULL /* pse */,
-    NULL /* tsc */, NULL /* msr */, NULL /* pae */, NULL /* mce */,
-    NULL /* cx8 */ /* AMD CMPXCHG8B */, NULL /* apic */, NULL, "syscall",
-    NULL /* mtrr */, NULL /* pge */, NULL /* mca */, NULL /* cmov */,
-    NULL /* pat */, NULL /* pse36 */, NULL, NULL /* Linux mp */,
-    "nx|xd", NULL, "mmxext", NULL /* mmx */,
-    NULL /* fxsr */, "fxsr_opt|ffxsr", "pdpe1gb" /* AMD Page1GB */, "rdtscp",
-    NULL, "lm|i64", "3dnowext", "3dnow",
-};
-static const char *ext3_feature_name[] = {
-    "lahf_lm" /* AMD LahfSahf */, "cmp_legacy", "svm", "extapic" /* AMD ExtApicSpace */,
-    "cr8legacy" /* AMD AltMovCr8 */, "abm", "sse4a", "misalignsse",
-    "3dnowprefetch", "osvw", "ibs", "xop",
-    "skinit", "wdt", NULL, "lwp",
-    "fma4", "tce", NULL, "nodeid_msr",
-    NULL, "tbm", "topoext", "perfctr_core",
-    "perfctr_nb", NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-};
-
-static const char *ext4_feature_name[] = {
-    NULL, NULL, "xstore", "xstore-en",
-    NULL, NULL, "xcrypt", "xcrypt-en",
-    "ace2", "ace2-en", "phe", "phe-en",
-    "pmm", "pmm-en", NULL, NULL,
-    NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-};
-
-static const char *kvm_feature_name[] = {
-    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock",
-    "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", NULL,
-    NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-};
-
-static const char *svm_feature_name[] = {
-    "npt", "lbrv", "svm_lock", "nrip_save",
-    "tsc_scale", "vmcb_clean",  "flushbyasid", "decodeassists",
-    NULL, NULL, "pause_filter", NULL,
-    "pfthreshold", NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL,
-};
-
-static const char *cpuid_7_0_ebx_feature_name[] = {
-    "fsgsbase", NULL, NULL, "bmi1", "hle", "avx2", NULL, "smep",
-    "bmi2", "erms", "invpcid", "rtm", NULL, NULL, NULL, NULL,
-    NULL, NULL, "rdseed", "adx", "smap", NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
-};
-
 typedef struct FeatureWordInfo {
-    const char **feat_names;
     uint32_t cpuid_eax;   /* Input EAX for CPUID */
     bool cpuid_needs_ecx; /* CPUID instruction uses ECX as input */
     uint32_t cpuid_ecx;   /* Input ECX value for CPUID */
@@ -160,35 +69,27 @@ typedef struct FeatureWordInfo {
 
 static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
     [FEAT_1_EDX] = {
-        .feat_names = feature_name,
         .cpuid_eax = 1, .cpuid_reg = R_EDX,
     },
     [FEAT_1_ECX] = {
-        .feat_names = ext_feature_name,
         .cpuid_eax = 1, .cpuid_reg = R_ECX,
     },
     [FEAT_8000_0001_EDX] = {
-        .feat_names = ext2_feature_name,
         .cpuid_eax = 0x80000001, .cpuid_reg = R_EDX,
     },
     [FEAT_8000_0001_ECX] = {
-        .feat_names = ext3_feature_name,
         .cpuid_eax = 0x80000001, .cpuid_reg = R_ECX,
     },
     [FEAT_C000_0001_EDX] = {
-        .feat_names = ext4_feature_name,
         .cpuid_eax = 0xC0000001, .cpuid_reg = R_EDX,
     },
     [FEAT_KVM] = {
-        .feat_names = kvm_feature_name,
         .cpuid_eax = KVM_CPUID_FEATURES, .cpuid_reg = R_EAX,
     },
     [FEAT_SVM] = {
-        .feat_names = svm_feature_name,
         .cpuid_eax = 0x8000000A, .cpuid_reg = R_EDX,
     },
     [FEAT_7_0_EBX] = {
-        .feat_names = cpuid_7_0_ebx_feature_name,
         .cpuid_eax = 7,
         .cpuid_needs_ecx = true, .cpuid_ecx = 0,
         .cpuid_reg = R_EBX,
-- 
1.8.3.1

  parent reply	other threads:[~2013-07-15 22:27 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15 22:25 [Qemu-devel] [PATCH qom-cpu 00/21 v9] target-i386: convert CPU features into properties Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 01/20] target-i386: Move hyperv_* static globals to X86CPU Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 02/20] target-i386: convert 'hv_spinlocks' to static property Igor Mammedov
2013-11-27 17:55   ` Andreas Färber
2013-11-27 18:05     ` Paolo Bonzini
2013-11-27 18:21     ` Igor Mammedov
2013-11-27 21:21     ` Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 03/20] target-i386: convert 'hv_relaxed' " Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 04/20] target-i386: convert 'hv_vapic' " Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 05/20] target-i386: convert 'check' and 'enforce' to static properties Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 06/20] target-i386: cleanup 'foo' feature handling' Igor Mammedov
2013-12-16 16:51   ` Eric Blake
2013-12-19 16:32     ` Andreas Färber
2013-07-15 22:26 ` [Qemu-devel] [PATCH 07/20] target-i386: cleanup 'foo=val' feature handling Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 08/20] target-i386: cpu: convert 'level' to static property Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 09/20] target-i386: cpu: convert 'xlevel' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 10/20] target-i386: cpu: convert 'family' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 11/20] target-i386: cpu: convert 'model' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 12/20] target-i386: cpu: convert 'stepping' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 13/20] target-i386: cpu: convert 'vendor' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 14/20] target-i386: cpu: convert 'model-id' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 15/20] target-i386: cpu: convert 'tsc-frequency' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 15/21] target-i386: cpu: substitute '_' with '-' for +-foo feature bits as well Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 16/21] target-i386: cpu: convert 'tsc-frequency' to static property Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 16/20] target-i386: set [+-]feature using static properties Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 17/20] qdev: introduce QDEV_FIND_PROP_FROM_BIT and qdev_prop_find_bit() Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 17/20] qdev: introduce qdev_prop_find_bit() Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 17/21] target-i386: set [+-]feature using static properties Igor Mammedov
2013-10-15 16:22   ` Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 18/21] qdev: introduce QDEV_FIND_PROP_FROM_BIT and qdev_prop_find_bit() Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 18/20] target-i386: use static properties in check_features_against_host() to print CPUID feature names Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 19/21] " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 19/20] target-i386: use static properties to list CPUID features Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 20/20] target-i386: remove unused *_feature_name arrays Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 20/21] target-i386: use static properties to list CPUID features Igor Mammedov
2013-07-15 22:26 ` Igor Mammedov [this message]
2013-10-14 12:09 ` [Qemu-devel] [PATCH qom-cpu 00/21 v9] target-i386: convert CPU features into properties Igor Mammedov
2013-10-14 18:05   ` Andreas Färber
2013-10-15 12:27   ` Vadim Rozenfeld
2013-11-25 16:56 ` Igor Mammedov
2013-12-15 21:48 ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373927181-24247-29-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vrozenfe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).