qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: mrhines@linux.vnet.ibm.com
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, quintela@redhat.com, knoel@redhat.com,
	owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com,
	gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com
Subject: [Qemu-devel] [PATCH v3 resend 2/8] rdma: bugfix: ram_control_save_page()
Date: Tue, 16 Jul 2013 12:48:20 -0400	[thread overview]
Message-ID: <1373993306-25764-3-git-send-email-mrhines@linux.vnet.ibm.com> (raw)
In-Reply-To: <1373993306-25764-1-git-send-email-mrhines@linux.vnet.ibm.com>

From: "Michael R. Hines" <mrhines@us.ibm.com>

We were not checking for a valid 'bytes_sent' pointer before accessing it.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael R. Hines <mrhines@us.ibm.com>
---
 savevm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/savevm.c b/savevm.c
index e0491e7..03fc4d9 100644
--- a/savevm.c
+++ b/savevm.c
@@ -662,7 +662,7 @@ size_t ram_control_save_page(QEMUFile *f, ram_addr_t block_offset,
                                     offset, size, bytes_sent);
 
         if (ret != RAM_SAVE_CONTROL_DELAYED) {
-            if (*bytes_sent > 0) {
+            if (bytes_sent && *bytes_sent > 0) {
                 qemu_update_position(f, *bytes_sent);
             } else if (ret < 0) {
                 qemu_file_set_error(f, ret);
-- 
1.7.10.4

  parent reply	other threads:[~2013-07-16 16:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16 16:48 [Qemu-devel] [PATCH v3 resend 0/8] rdma: core logic mrhines
2013-07-16 16:48 ` [Qemu-devel] [PATCH v3 resend 1/8] rdma: update documentation to reflect new unpin support mrhines
2013-07-16 16:48 ` mrhines [this message]
2013-07-16 16:48 ` [Qemu-devel] [PATCH v3 resend 3/8] rdma: introduce ram_handle_compressed() mrhines
2013-07-16 16:48 ` [Qemu-devel] [PATCH v3 resend 4/8] rdma: core logic mrhines
2013-07-18  7:30   ` Marcel Apfelbaum
2013-07-18 12:07     ` Michael R. Hines
2013-07-18 12:22       ` Paolo Bonzini
2013-07-16 16:48 ` [Qemu-devel] [PATCH v3 resend 5/8] rdma: send pc.ram mrhines
2013-07-16 16:48 ` [Qemu-devel] [PATCH v3 resend 6/8] rdma: allow state transitions between other states besides ACTIVE mrhines
2013-07-16 16:48 ` [Qemu-devel] [PATCH v3 resend 7/8] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition mrhines
2013-07-16 16:48 ` [Qemu-devel] [PATCH v3 resend 8/8] rdma: account for the time spent in MIG_STATE_SETUP through QMP mrhines
  -- strict thread matches above, loose matches on Subject: below --
2013-07-22 14:01 [Qemu-devel] [PATCH v3 resend 0/8] rdma: core logic mrhines
2013-07-22 14:01 ` [Qemu-devel] [PATCH v3 resend 2/8] rdma: bugfix: ram_control_save_page() mrhines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373993306-25764-3-git-send-email-mrhines@linux.vnet.ibm.com \
    --to=mrhines@linux.vnet.ibm.com \
    --cc=abali@us.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=chegu_vinod@hp.com \
    --cc=gokul@us.ibm.com \
    --cc=knoel@redhat.com \
    --cc=mrhines@us.ibm.com \
    --cc=owasserm@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).