From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzO9F-0000ga-7M for qemu-devel@nongnu.org; Wed, 17 Jul 2013 05:35:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzO9C-0005Pk-Kq for qemu-devel@nongnu.org; Wed, 17 Jul 2013 05:35:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzO9C-0005PN-DC for qemu-devel@nongnu.org; Wed, 17 Jul 2013 05:35:46 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6H9ZjMO027323 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Jul 2013 05:35:45 -0400 From: Stefan Hajnoczi Date: Wed, 17 Jul 2013 17:35:19 +0800 Message-Id: <1374053720-28420-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1374053720-28420-1-git-send-email-stefanha@redhat.com> References: <1374053720-28420-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 2/3] migration: notify migration state before starting thread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Stefan Hajnoczi , Juan Quintela The migration thread runs outside the QEMU global mutex when possible. Therefore we must notify migration state change *before* starting the migration thread. This allows registered listeners to act before live migration iterations begin. Therefore they can get into a state that allows for live migration. When the migration thread starts everything will be ready. Signed-off-by: Stefan Hajnoczi --- migration.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 9f5a423..b4daf13 100644 --- a/migration.c +++ b/migration.c @@ -625,7 +625,9 @@ void migrate_fd_connect(MigrationState *s) qemu_file_set_rate_limit(s->file, s->bandwidth_limit / XFER_LIMIT_RATIO); + /* Notify before starting migration thread */ + notifier_list_notify(&migration_state_notifiers, s); + qemu_thread_create(&s->thread, migration_thread, s, QEMU_THREAD_JOINABLE); - notifier_list_notify(&migration_state_notifiers, s); } -- 1.8.1.4