From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzTMT-00069u-L8 for qemu-devel@nongnu.org; Wed, 17 Jul 2013 11:09:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzTMO-0001Fw-2r for qemu-devel@nongnu.org; Wed, 17 Jul 2013 11:09:49 -0400 Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 17 Jul 2013 17:05:21 +0200 Message-Id: <1374073524-8469-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1374073524-8469-1-git-send-email-pbonzini@redhat.com> References: <1374073524-8469-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 2/5] iscsi: fix -ENOSPC in iscsi_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Lieven , qemu-stable@nongnu.org From: Peter Lieven the -ENOPSC case did not work due to the missing goto. Reported-by: Kevin Wolf Signed-off-by: Peter Lieven Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- block/iscsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/iscsi.c b/block/iscsi.c index fa5252c..91b602c 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1272,6 +1272,7 @@ static int iscsi_create(const char *filename, QEMUOptionParameter *options) } if (bs.total_sectors < total_size) { ret = -ENOSPC; + goto out; } ret = 0; -- 1.8.1.4