From: Ian Main <imain@redhat.com>
To: qemu-devel@nongnu.org
Cc: Ian Main <imain@redhat.com>
Subject: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none.
Date: Wed, 17 Jul 2013 13:04:22 -0700 [thread overview]
Message-ID: <1374091462-18391-5-git-send-email-imain@redhat.com> (raw)
In-Reply-To: <1374091462-18391-1-git-send-email-imain@redhat.com>
qcow2 supports backing files so it makes sense to default to qcow2
for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing
drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE
breaks tests but that could be fixed if we wanted it.
Signed-off-by: Ian Main <imain@redhat.com>
---
blockdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index 000dea6..805b0e5 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1462,7 +1462,7 @@ void qmp_drive_backup(const char *device, const char *target,
}
if (!has_format) {
- format = mode == NEW_IMAGE_MODE_EXISTING ? NULL : bs->drv->format_name;
+ format = mode == NEW_IMAGE_MODE_EXISTING ? NULL : "qcow2";
}
if (format) {
drv = bdrv_find_format(format);
--
1.8.1.4
next prev parent reply other threads:[~2013-07-17 20:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 20:04 [Qemu-devel] [PATCH V4 0/4] Implement sync modes for drive-backup Ian Main
2013-07-17 20:04 ` [Qemu-devel] [PATCH V4 1/4] " Ian Main
2013-07-18 17:19 ` Eric Blake
2013-07-18 19:06 ` Ian Main
2013-07-18 19:54 ` Eric Blake
2013-07-19 21:56 ` Ian Main
2013-07-17 20:04 ` [Qemu-devel] [PATCH V4 2/4] Add tests for sync modes 'TOP' and 'NONE' Ian Main
2013-07-17 20:04 ` [Qemu-devel] [PATCH V4 3/4] Add backing drive while performing backup Ian Main
2013-07-18 6:39 ` Fam Zheng
2013-07-18 13:13 ` Paolo Bonzini
2013-07-19 1:13 ` Fam Zheng
2013-07-19 20:15 ` Paolo Bonzini
2013-07-17 20:04 ` Ian Main [this message]
2013-07-18 17:27 ` [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none Eric Blake
2013-07-18 17:32 ` Eric Blake
2013-07-18 18:03 ` Ian Main
2013-07-18 18:48 ` Eric Blake
2013-07-18 18:06 ` Ian Main
-- strict thread matches above, loose matches on Subject: below --
2013-07-18 18:47 Ian Main
2013-07-18 18:56 ` Eric Blake
2013-07-18 19:13 ` Ian Main
2013-07-18 19:55 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374091462-18391-5-git-send-email-imain@redhat.com \
--to=imain@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).