qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Markus Armbruster <armbru@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL 3/5] milkymist-minimac2: Fix minimac2_read/_write tracepoints
Date: Thu, 18 Jul 2013 11:49:27 +0800	[thread overview]
Message-ID: <1374119369-26496-4-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1374119369-26496-1-git-send-email-stefanha@redhat.com>

From: Markus Armbruster <armbru@redhat.com>

Broken in milkymist-minimac.c from the start (commit 0742454),
faithfully moved to milkymist-minimac2.c (commit 57aa265).

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/net/milkymist-minimac2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c
index 2ef4ac3..becd26c 100644
--- a/hw/net/milkymist-minimac2.c
+++ b/hw/net/milkymist-minimac2.c
@@ -355,7 +355,7 @@ minimac2_write(void *opaque, hwaddr addr, uint64_t value,
 {
     MilkymistMinimac2State *s = opaque;
 
-    trace_milkymist_minimac2_memory_read(addr, value);
+    trace_milkymist_minimac2_memory_write(addr, value);
 
     addr >>= 2;
     switch (addr) {
-- 
1.8.1.4

  parent reply	other threads:[~2013-07-18  3:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-18  3:49 [Qemu-devel] [PULL 0/5] Tracing patches Stefan Hajnoczi
2013-07-18  3:49 ` [Qemu-devel] [PULL 1/5] cleanup-trace-events.pl: New Stefan Hajnoczi
2013-07-18  3:49 ` [Qemu-devel] [PULL 2/5] slavio_misc: Fix slavio_led_mem_readw/_writew tracepoints Stefan Hajnoczi
2013-07-18  3:49 ` Stefan Hajnoczi [this message]
2013-07-18  3:49 ` [Qemu-devel] [PULL 4/5] trace-events: Drop unused events Stefan Hajnoczi
2013-07-18  3:49 ` [Qemu-devel] [PULL 5/5] trace-events: Fix up source file comments Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374119369-26496-4-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).