From: Laszlo Ersek <lersek@redhat.com>
To: qemu-devel@nongnu.org, pbonzini@redhat.com, gaowanlong@cn.fujitsu.com
Subject: [Qemu-devel] [RFC 4/6] OptsVisitor: rebase opts_type_uint64() to parse_uint_full()
Date: Thu, 18 Jul 2013 15:59:22 +0200 [thread overview]
Message-ID: <1374155964-11278-5-git-send-email-lersek@redhat.com> (raw)
In-Reply-To: <1374155964-11278-1-git-send-email-lersek@redhat.com>
Simplify the code in preparation for the next patch.
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
qapi/opts-visitor.c | 23 +++++------------------
1 files changed, 5 insertions(+), 18 deletions(-)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index 287aa06..ce6c290 100644
--- a/qapi/opts-visitor.c
+++ b/qapi/opts-visitor.c
@@ -384,6 +384,7 @@ opts_type_uint64(Visitor *v, uint64_t *obj, const char *name, Error **errp)
OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
const QemuOpt *opt;
const char *str;
+ unsigned long long val;
if (ov->list_mode == LM_UNSIGNED_INTERVAL) {
*obj = ov->range_next.u;
@@ -394,26 +395,12 @@ opts_type_uint64(Visitor *v, uint64_t *obj, const char *name, Error **errp)
if (!opt) {
return;
}
-
str = opt->str;
- if (str != NULL) {
- while (isspace((unsigned char)*str)) {
- ++str;
- }
-
- if (*str != '-' && *str != '\0') {
- unsigned long long val;
- char *endptr;
- /* non-empty, non-negative subject sequence */
- errno = 0;
- val = strtoull(str, &endptr, 0);
- if (*endptr == '\0' && errno == 0 && val <= UINT64_MAX) {
- *obj = val;
- processed(ov, name);
- return;
- }
- }
+ if (parse_uint_full(str, &val, 0) == 0 && val <= UINT64_MAX) {
+ *obj = val;
+ processed(ov, name);
+ return;
}
error_set(errp, QERR_INVALID_PARAMETER_VALUE, opt->name,
"an uint64 value");
--
1.7.1
next prev parent reply other threads:[~2013-07-18 13:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 13:59 [Qemu-devel] [RFC 0/6] OptsVisitor: support / flatten integer ranges for repeating options Laszlo Ersek
2013-07-18 13:59 ` [Qemu-devel] [RFC 1/6] OptsVisitor: introduce basic list modes Laszlo Ersek
2013-07-18 14:53 ` Paolo Bonzini
2013-07-18 15:45 ` Laszlo Ersek
2013-07-18 13:59 ` [Qemu-devel] [RFC 2/6] OptsVisitor: introduce list modes for interval flattening Laszlo Ersek
2013-07-18 14:56 ` Paolo Bonzini
2013-07-18 15:57 ` Laszlo Ersek
2013-07-18 16:03 ` Paolo Bonzini
2013-07-18 16:14 ` Laszlo Ersek
2013-07-18 13:59 ` [Qemu-devel] [RFC 3/6] OptsVisitor: opts_type_int(): recognize intervals when LM_IN_PROGRESS Laszlo Ersek
2013-07-18 13:59 ` Laszlo Ersek [this message]
2013-07-18 13:59 ` [Qemu-devel] [RFC 5/6] OptsVisitor: opts_type_uint64(): " Laszlo Ersek
2013-07-18 13:59 ` [Qemu-devel] [RFC 6/6] OptsVisitor: don't try to flatten overlong integer ranges Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374155964-11278-5-git-send-email-lersek@redhat.com \
--to=lersek@redhat.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).