From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V00ZL-0007gP-Hf for qemu-devel@nongnu.org; Thu, 18 Jul 2013 22:37:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V00ZI-0003G3-33 for qemu-devel@nongnu.org; Thu, 18 Jul 2013 22:37:19 -0400 Received: from mail-pd0-x22a.google.com ([2607:f8b0:400e:c02::22a]:63863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V00ZH-0003Fo-SY for qemu-devel@nongnu.org; Thu, 18 Jul 2013 22:37:15 -0400 Received: by mail-pd0-f170.google.com with SMTP id x11so3742480pdj.15 for ; Thu, 18 Jul 2013 19:37:15 -0700 (PDT) From: Pawit Pornkitprasan Date: Fri, 19 Jul 2013 11:36:41 +0900 Message-Id: <1374201401-11244-1-git-send-email-p.pawit@gmail.com> Subject: [Qemu-devel] [PATCH] migration: don't use uninitialized variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Pawit Pornkitprasan , Ryousei Takano , Juan Quintela The qmp_migrate method uses the 'blk' and 'inc' parameter without checking if they're valid or not (they may be uninitialized if command is received via QMP) Signed-off-by: Pawit Pornkitprasan --- migration.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index 9f5a423..f3d1ff7 100644 --- a/migration.c +++ b/migration.c @@ -385,8 +385,8 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk, MigrationParams params; const char *p; - params.blk = blk; - params.shared = inc; + params.blk = has_blk && blk; + params.shared = has_inc && inc; if (s->state == MIG_STATE_ACTIVE) { error_set(errp, QERR_MIGRATION_ACTIVE); -- 1.8.1.2