qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kwok Cheung Yeung <kcy@codesourcery.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Kwok Cheung Yeung <kcy@codesourcery.com>,
	riku.voipio@iki.fi, aurelien@aurel32.net
Subject: [Qemu-devel] [PATCH v2] linux-user: Handle microMIPS encoding when processing trap exceptions
Date: Fri, 19 Jul 2013 07:47:13 -0700	[thread overview]
Message-ID: <1374245233-14732-1-git-send-email-kcy@codesourcery.com> (raw)

Decode trap instructions during the handling of an EXCP_TRAP according to
the current ISA mode.

Signed-off-by: Kwok Cheung Yeung <kcy@codesourcery.com>
---
 linux-user/main.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

v2: Read microMIPS instructions sequentially as 16-bit values to avoid
    endianess issues. Add braces to if statement to conform to formatting
    standards.

diff --git a/linux-user/main.c b/linux-user/main.c
index 7f15d3d..7faa945 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -2372,14 +2372,30 @@ done_syscall:
                 abi_ulong trap_instr;
                 unsigned int code = 0;
 
-                ret = get_user_ual(trap_instr, env->active_tc.PC);
+                if (env->hflags & MIPS_HFLAG_M16) {
+                    /* microMIPS mode */
+                    abi_ulong instr[2];
+
+                    ret = get_user_u16(instr[0], env->active_tc.PC) ||
+                          get_user_u16(instr[1], env->active_tc.PC + 2);
+
+                    trap_instr = (instr[0] << 16) | instr[1];
+                } else {
+                    ret = get_user_ual(trap_instr, env->active_tc.PC);
+                }
+
                 if (ret != 0) {
                     goto error;
                 }
 
                 /* The immediate versions don't provide a code.  */
                 if (!(trap_instr & 0xFC000000)) {
-                    code = ((trap_instr >> 6) & ((1 << 10) - 1));
+                    if (env->hflags & MIPS_HFLAG_M16) {
+                        /* microMIPS mode */
+                        code = ((trap_instr >> 12) & ((1 << 4) - 1));
+                    } else {
+                        code = ((trap_instr >> 6) & ((1 << 10) - 1));
+                    }
                 }
 
                 if (do_break(env, &info, code) != 0) {
-- 
1.8.3.3

             reply	other threads:[~2013-07-19 14:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19 14:47 Kwok Cheung Yeung [this message]
2013-07-19 14:52 ` [Qemu-devel] [PATCH v2] linux-user: Handle microMIPS encoding when processing trap exceptions Peter Maydell
2013-07-19 15:09   ` Kwok Cheung Yeung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374245233-14732-1-git-send-email-kcy@codesourcery.com \
    --to=kcy@codesourcery.com \
    --cc=aurelien@aurel32.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).