From: Liu Ping Fan <qemulist@gmail.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Alex Bligh <alex@alex.org.uk>,
Anthony Liguori <anthony@codemonkey.ws>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [RFC 7/8] block: associate BlockDriverState with AioContext
Date: Sun, 21 Jul 2013 16:43:04 +0800 [thread overview]
Message-ID: <1374396185-10870-8-git-send-email-pingfank@linux.vnet.ibm.com> (raw)
In-Reply-To: <1374396185-10870-1-git-send-email-pingfank@linux.vnet.ibm.com>
The default aio for BDS is qemu_aio_context, while for data plane,
it will has its own ctx. Relating BDS with AioContext can help
block layer to determine its running environment. Some stuff like
timers need such info, so that they can run in the correct
environment.
Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
---
block.c | 6 ++++++
hw/block/dataplane/virtio-blk.c | 1 +
include/block/block.h | 1 +
include/block/block_int.h | 1 +
4 files changed, 9 insertions(+)
diff --git a/block.c b/block.c
index daf5717..c6b7b6c 100644
--- a/block.c
+++ b/block.c
@@ -315,6 +315,12 @@ BlockDriverState *bdrv_new(const char *device_name)
return bs;
}
+void bdrv_set_aio_context(BlockDriverState *bs, AioContext *ctx)
+{
+ assert(ctx);
+ bs->ctx = ctx;
+}
+
void bdrv_add_close_notifier(BlockDriverState *bs, Notifier *notify)
{
notifier_list_add(&bs->close_notifiers, notify);
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 5fde06f..ec477b0 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -378,6 +378,7 @@ void virtio_blk_data_plane_start(VirtIOBlockDataPlane *s)
}
s->ctx = aio_context_new();
+ bdrv_set_aio_context(s->bs, s->ctx);
/* Set up guest notifier (irq) */
if (k->set_guest_notifiers(qbus->parent, 1, true) != 0) {
diff --git a/include/block/block.h b/include/block/block.h
index cb44f27..23e743d 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -128,6 +128,7 @@ int bdrv_create(BlockDriver *drv, const char* filename,
QEMUOptionParameter *options);
int bdrv_create_file(const char* filename, QEMUOptionParameter *options);
BlockDriverState *bdrv_new(const char *device_name);
+void bdrv_set_aio_context(BlockDriverState *bs, AioContext *ctx);
void bdrv_make_anon(BlockDriverState *bs);
void bdrv_swap(BlockDriverState *bs_new, BlockDriverState *bs_old);
void bdrv_append(BlockDriverState *bs_new, BlockDriverState *bs_top);
diff --git a/include/block/block_int.h b/include/block/block_int.h
index cd0e0a8..801d1c1 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -299,6 +299,7 @@ struct BlockDriverState {
QLIST_HEAD(, BdrvTrackedRequest) tracked_requests;
+ AioContext *ctx;
/* long-running background operation */
BlockJob *job;
--
1.8.1.4
next prev parent reply other threads:[~2013-07-21 8:51 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 8:42 [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff Liu Ping Fan
2013-07-21 8:42 ` [Qemu-devel] [RFC 1/8] timer: associate alarm_timer with AioContext Liu Ping Fan
2013-07-22 6:55 ` Jan Kiszka
2013-07-21 8:42 ` [Qemu-devel] [RFC 2/8] timer: pick out timer list info from QemuClock Liu Ping Fan
2013-07-21 8:43 ` [Qemu-devel] [RFC 3/8] timer: make timers_state static Liu Ping Fan
2013-07-22 6:36 ` Jan Kiszka
2013-07-22 17:40 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-07-21 8:43 ` [Qemu-devel] [RFC 4/8] timer: protect timers_state with lock Liu Ping Fan
2013-07-22 6:40 ` Jan Kiszka
2013-07-21 8:43 ` [Qemu-devel] [RFC 5/8] timer: associate timer with AioContext Liu Ping Fan
2013-07-21 8:43 ` [Qemu-devel] [RFC 6/8] timer: run timers on aio_poll Liu Ping Fan
2013-07-21 9:55 ` Alex Bligh
2013-07-23 2:56 ` liu ping fan
2013-07-23 14:22 ` Alex Bligh
2013-07-21 8:43 ` Liu Ping Fan [this message]
2013-07-21 8:43 ` [Qemu-devel] [RFC 8/8] block: enable throttle with aiocontext Liu Ping Fan
2013-07-21 9:53 ` [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff Alex Bligh
2013-07-22 4:38 ` liu ping fan
2013-07-22 6:28 ` Jan Kiszka
2013-07-23 2:51 ` liu ping fan
2013-07-25 11:44 ` Stefan Hajnoczi
2013-07-25 12:01 ` Jan Kiszka
2013-07-22 9:40 ` Alex Bligh
2013-07-22 10:18 ` liu ping fan
2013-07-23 2:53 ` liu ping fan
2013-07-23 10:30 ` Paolo Bonzini
2013-07-24 1:28 ` liu ping fan
2013-07-24 6:42 ` Paolo Bonzini
2013-07-24 7:31 ` Alex Bligh
2013-07-24 7:43 ` Paolo Bonzini
2013-07-24 8:01 ` Alex Bligh
2013-07-24 8:19 ` Paolo Bonzini
2013-07-24 8:37 ` Alex Bligh
2013-07-24 11:28 ` Paolo Bonzini
2013-07-24 8:30 ` liu ping fan
2013-07-24 7:43 ` liu ping fan
2013-07-24 7:54 ` Paolo Bonzini
2013-07-24 8:06 ` Alex Bligh
2013-07-24 14:46 ` [Qemu-devel] [PATCHv2a] [RFC 8/7 (really)] Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack Alex Bligh
2013-07-23 14:21 ` [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff Alex Bligh
2013-07-25 11:47 ` Stefan Hajnoczi
2013-07-25 12:05 ` Stefan Hajnoczi
2013-07-25 12:21 ` Alex Bligh
2013-07-25 12:32 ` Jan Kiszka
2013-07-25 12:35 ` Paolo Bonzini
2013-07-25 12:38 ` Jan Kiszka
2013-07-25 12:41 ` Stefan Hajnoczi
2013-07-25 12:48 ` Jan Kiszka
2013-07-25 13:02 ` Paolo Bonzini
2013-07-25 13:06 ` Jan Kiszka
2013-07-25 13:31 ` Stefan Hajnoczi
2013-07-25 14:01 ` Jan Kiszka
2013-07-25 12:59 ` Paolo Bonzini
2013-07-25 18:53 ` Alex Bligh
2013-07-26 8:43 ` Stefan Hajnoczi
2013-07-26 9:08 ` Alex Bligh
2013-07-26 9:19 ` Paolo Bonzini
2013-07-29 8:58 ` Kevin Wolf
2013-07-29 10:22 ` Alex Bligh
2013-07-29 10:45 ` Paolo Bonzini
2013-07-31 9:02 ` Stefan Hajnoczi
2013-07-26 10:05 ` Jan Kiszka
2013-07-26 19:29 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374396185-10870-8-git-send-email-pingfank@linux.vnet.ibm.com \
--to=qemulist@gmail.com \
--cc=alex@alex.org.uk \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).