qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [PATCH 2/6] target-xtensa: add fallthrough markers
Date: Sun, 21 Jul 2013 16:05:02 +0400	[thread overview]
Message-ID: <1374408306-2684-3-git-send-email-jcmvbkbc@gmail.com> (raw)
In-Reply-To: <1374408306-2684-1-git-send-email-jcmvbkbc@gmail.com>

Explicitly mark cases where we are deliberately falling through to the
following code.

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 target-xtensa/op_helper.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target-xtensa/op_helper.c b/target-xtensa/op_helper.c
index 4c41de0..834fe90 100644
--- a/target-xtensa/op_helper.c
+++ b/target-xtensa/op_helper.c
@@ -448,8 +448,10 @@ void HELPER(check_atomctl)(CPUXtensaState *env, uint32_t pc, uint32_t vaddr)
     switch (access & PAGE_CACHE_MASK) {
     case PAGE_CACHE_WB:
         atomctl >>= 2;
+        /* fall through */
     case PAGE_CACHE_WT:
         atomctl >>= 2;
+        /* fall through */
     case PAGE_CACHE_BYPASS:
         if ((atomctl & 0x3) == 0) {
             HELPER(exception_cause_vaddr)(env, pc,
-- 
1.8.1.4

  parent reply	other threads:[~2013-07-21 12:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21 12:05 [Qemu-devel] [PATCH 0/6] target-xtensa queue Max Filippov
2013-07-21 12:05 ` [Qemu-devel] [PATCH 1/6] target-xtensa: add extui unit test Max Filippov
2013-07-21 12:05 ` Max Filippov [this message]
2013-07-21 12:05 ` [Qemu-devel] [PATCH 3/6] target-xtensa: avoid double-stopping at breakpoints Max Filippov
2013-07-21 12:05 ` [Qemu-devel] [PATCH 4/6] tests/tcg/xtensa: Fix out-of-tree build Max Filippov
2013-07-21 12:05 ` [Qemu-devel] [PATCH 5/6] target-xtensa: don't generate dead code to access invalid SRs Max Filippov
2013-07-21 12:05 ` [Qemu-devel] [PATCH 6/6] target-xtensa: check register window inline Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374408306-2684-3-git-send-email-jcmvbkbc@gmail.com \
    --to=jcmvbkbc@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).