From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0sOm-00014N-2J for qemu-devel@nongnu.org; Sun, 21 Jul 2013 08:06:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0sOl-0007fI-8X for qemu-devel@nongnu.org; Sun, 21 Jul 2013 08:05:59 -0400 Received: from mail-lb0-x236.google.com ([2a00:1450:4010:c04::236]:36312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0sOl-0007fA-2X for qemu-devel@nongnu.org; Sun, 21 Jul 2013 08:05:59 -0400 Received: by mail-lb0-f182.google.com with SMTP id r11so4472337lbv.41 for ; Sun, 21 Jul 2013 05:05:58 -0700 (PDT) From: Max Filippov Date: Sun, 21 Jul 2013 16:05:02 +0400 Message-Id: <1374408306-2684-3-git-send-email-jcmvbkbc@gmail.com> In-Reply-To: <1374408306-2684-1-git-send-email-jcmvbkbc@gmail.com> References: <1374408306-2684-1-git-send-email-jcmvbkbc@gmail.com> Subject: [Qemu-devel] [PATCH 2/6] target-xtensa: add fallthrough markers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Max Filippov , Anthony Liguori Explicitly mark cases where we are deliberately falling through to the following code. Signed-off-by: Max Filippov --- target-xtensa/op_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-xtensa/op_helper.c b/target-xtensa/op_helper.c index 4c41de0..834fe90 100644 --- a/target-xtensa/op_helper.c +++ b/target-xtensa/op_helper.c @@ -448,8 +448,10 @@ void HELPER(check_atomctl)(CPUXtensaState *env, uint32_t pc, uint32_t vaddr) switch (access & PAGE_CACHE_MASK) { case PAGE_CACHE_WB: atomctl >>= 2; + /* fall through */ case PAGE_CACHE_WT: atomctl >>= 2; + /* fall through */ case PAGE_CACHE_BYPASS: if ((atomctl & 0x3) == 0) { HELPER(exception_cause_vaddr)(env, pc, -- 1.8.1.4