From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>,
Paul Mackerras <paulus@samba.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [RFC PATCH] spapr-vscsi: add task management
Date: Mon, 22 Jul 2013 10:23:32 +1000 [thread overview]
Message-ID: <1374452612.3916.17.camel@pasglop> (raw)
In-Reply-To: <51EC7AC9.3080306@ozlabs.ru>
On Mon, 2013-07-22 at 10:20 +1000, Alexey Kardashevskiy wrote:
> May be. But there was no way to get this callback called till I started
> calling scsi_req_cancel in this patch so I would not split.
You probably still should. The smaller each individual patch, the better
(in part because that makes them easier to review).
So a first patch adding the new callback, then a second patch adding the
task management.
Cheers,
Ben.
next prev parent reply other threads:[~2013-07-22 0:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 10:04 [Qemu-devel] [RFC PATCH] spapr-vscsi: add task management Alexey Kardashevskiy
2013-07-21 21:34 ` Benjamin Herrenschmidt
2013-07-21 23:09 ` Paolo Bonzini
2013-07-22 6:07 ` [Qemu-devel] [PATCH v2] " Alexey Kardashevskiy
2013-07-22 0:20 ` [Qemu-devel] [RFC PATCH] " Alexey Kardashevskiy
2013-07-22 0:23 ` Benjamin Herrenschmidt [this message]
2013-07-22 0:57 ` Alexey Kardashevskiy
2013-07-22 1:04 ` Benjamin Herrenschmidt
2013-07-22 6:30 ` Paolo Bonzini
2013-07-22 6:35 ` Benjamin Herrenschmidt
2013-07-22 9:23 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374452612.3916.17.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=aliguori@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).