Re: [Qemu-devel] [RFC PATCH] spapr-vscsi: add task management

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Mon, 2013-07-22 at 10:57 +1000, Alexey Kardashevskiy wrote:
> On 07/22/2013 10:23 AM, Benjamin Herrenschmidt wrote:
> > On Mon, 2013-07-22 at 10:20 +1000, Alexey Kardashevskiy wrote:
> >> May be. But there was no way to get this callback called till I started
> >> calling scsi_req_cancel in this patch so I would not split.
> > 
> > You probably still should. The smaller each individual patch, the better
> > (in part because that makes them easier to review).
> 
> 
> Should make it easier but in fact it does not for me :)

But you aren't the one reviewing it. This is how you are supposed to
submit patches. If you willingly decide to not follow that process then
don't be surprised if people complain or don't review them.

> > So a first patch adding the new callback, then a second patch adding the
> > task management.
> 
> I can even add tasks one-by-one :)
> 
> Come on, is this patch really big or even close to be called big?

Doesn't matter. At this point it's RFC so that's not a big deal, for a
final patch, it's about logical separation. The free_request callback
is not directly "linked" to task management though it happens to only
be called in that case. It's a pre-requisite to task management, make it
a separate patch.

Task management per-se could be a single patch, or could be split, up to
you really, but keep in mind that the smaller a patch, the more chances
it gets reviewed quickly.

Cheers,
Ben.