From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1B8L-0000Y3-0K for qemu-devel@nongnu.org; Mon, 22 Jul 2013 04:06:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1B8I-0001OC-CQ for qemu-devel@nongnu.org; Mon, 22 Jul 2013 04:06:16 -0400 Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]:33318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1B8I-0001Nr-6a for qemu-devel@nongnu.org; Mon, 22 Jul 2013 04:06:14 -0400 Received: by mail-pa0-f50.google.com with SMTP id fb1so6804281pad.9 for ; Mon, 22 Jul 2013 01:06:12 -0700 (PDT) From: Xu Wang Date: Mon, 22 Jul 2013 04:05:44 -0400 Message-Id: <1374480349-11412-1-git-send-email-cngesaint@gmail.com> Subject: [Qemu-devel] [PATCH V4 0/5] Redefine and export backing file loop check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@gmail.com, Xu Wang , famz@redhat.com, wdongxu@linux.vnet.ibm.com If there is loop exists in the backing file chain, many problems could be caused by it, such as no response and segment fault during system boot. Hence stopping backing file loop appear is very necessary. These patches refine and export loop checking function from collect_image_ info_list() to block.c and build a independent function named bdrv_ backing_file_loop_check(). Backing file loop checking is added before image created, before change backing file and before system boot. Updates from V3: 1. Comments fix for function bdrv_backing_file_loop_check(). 2. Add ret check for fseek()/fread() in get_lnk_target_file(). 3. Add limit of shortcuts filename length reading during comparing. 4. Add error_report() in driv_init(). 5. Remove redundant loop check in qcow2/qed_change_backing_file(). Updates from V2: 1. Removed parameter @chain from bdrv_backing_file_loop_check() 2. Comments and format fix, all patches were checked by checkpatch.pl 3. Fixed *bs leak. 4. Improved logic of .lnk file recognization. 5. Add filename lenth limit check in while() 6. Changed get_win_inode() to get_inode() and move all inode get method into it to make logic more simpler. 7. Added value of @fmt as suggested. 8. Added backing file loop check in qcow2.c/qed.c Xu Wang (5): block/qemu-img: Refine and export infinite loop checking in collect_image_info_list() block: Add WIN32 platform support for backing_file_loop_check() block: Check infinite loop in bdrv_img_create() block: Add backing file loop check in change_backing_file() block: Add infinite loop check in drive_init() block.c | 257 +++++++++++++++++++++++++++++++++++++++++++++++++- blockdev.c | 7 ++ include/block/block.h | 4 + qemu-img.c | 29 ++---- 4 files changed, 272 insertions(+), 25 deletions(-) -- 1.8.1.4