From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH v2 12/16] cpu/a15mpcore: QOM cast cleanup
Date: Tue, 23 Jul 2013 04:43:20 +0200 [thread overview]
Message-ID: <1374547404-11700-13-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1374547404-11700-1-git-send-email-afaerber@suse.de>
From: Andreas Färber <andreas.faerber@web.de>
Introduce type constant and cast macro and rename A15MPPrivState::busdev
field to parent_obj to enforce its use.
Prepares for QOM realize.
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
---
hw/cpu/a15mpcore.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/hw/cpu/a15mpcore.c b/hw/cpu/a15mpcore.c
index c736257..4f37964 100644
--- a/hw/cpu/a15mpcore.c
+++ b/hw/cpu/a15mpcore.c
@@ -23,8 +23,15 @@
/* A15MP private memory region. */
+#define TYPE_A15MPCORE_PRIV "a15mpcore_priv"
+#define A15MPCORE_PRIV(obj) \
+ OBJECT_CHECK(A15MPPrivState, (obj), TYPE_A15MPCORE_PRIV)
+
typedef struct A15MPPrivState {
- SysBusDevice busdev;
+ /*< private >*/
+ SysBusDevice parent_obj;
+ /*< public >*/
+
uint32_t num_cpu;
uint32_t num_irq;
MemoryRegion container;
@@ -39,7 +46,7 @@ static void a15mp_priv_set_irq(void *opaque, int irq, int level)
static int a15mp_priv_init(SysBusDevice *dev)
{
- A15MPPrivState *s = FROM_SYSBUS(A15MPPrivState, dev);
+ A15MPPrivState *s = A15MPCORE_PRIV(dev);
SysBusDevice *busdev;
const char *gictype = "arm_gic";
@@ -58,7 +65,7 @@ static int a15mp_priv_init(SysBusDevice *dev)
sysbus_pass_irq(dev, busdev);
/* Pass through inbound GPIO lines to the GIC */
- qdev_init_gpio_in(&s->busdev.qdev, a15mp_priv_set_irq, s->num_irq - 32);
+ qdev_init_gpio_in(DEVICE(dev), a15mp_priv_set_irq, s->num_irq - 32);
/* Memory map (addresses are offsets from PERIPHBASE):
* 0x0000-0x0fff -- reserved
@@ -101,7 +108,7 @@ static void a15mp_priv_class_init(ObjectClass *klass, void *data)
}
static const TypeInfo a15mp_priv_info = {
- .name = "a15mpcore_priv",
+ .name = TYPE_A15MPCORE_PRIV,
.parent = TYPE_SYS_BUS_DEVICE,
.instance_size = sizeof(A15MPPrivState),
.class_init = a15mp_priv_class_init,
--
1.8.1.4
next prev parent reply other threads:[~2013-07-23 2:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 2:43 [Qemu-devel] [PATCH v2 00/16] arm: A9MPCore+A15MPCore QOM'ification Andreas Färber
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 01/16] cpu/a9mpcore: QOM casting cleanup Andreas Färber
2013-07-23 22:48 ` Peter Maydell
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 02/16] cpu/a9mpcore: Split off instance_init Andreas Färber
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 03/16] intc/arm_gic: Extract public header hw/intc/arm_gic.h Andreas Färber
2013-07-25 15:40 ` Peter Maydell
2013-07-26 20:06 ` Andreas Färber
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 04/16] cpu/a9mpcore: Embed GICState Andreas Färber
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 05/16] misc/a9scu: QOM cleanups Andreas Färber
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 06/16] cpu/a9mpcore: Embed A9SCUState Andreas Färber
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 07/16] timer/arm_mptimer: QOM cast cleanup Andreas Färber
2013-07-23 22:50 ` Peter Maydell
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 08/16] timer/arm_mptimer: Convert to QOM realize Andreas Färber
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 09/16] cpu/a9mpcore: Embed ARMMPTimerState Andreas Färber
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 10/16] cpu/a9mpcore: Convert to QOM realize Andreas Färber
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 11/16] cpu/a9mpcore: Prepare for QOM embedding Andreas Färber
2013-07-23 2:43 ` Andreas Färber [this message]
2013-07-23 22:49 ` [Qemu-devel] [PATCH v2 12/16] cpu/a15mpcore: QOM cast cleanup Peter Maydell
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 13/16] cpu/a15mpcore: Split off instance_init Andreas Färber
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 14/16] cpu/a15mpcore: Embed GICState Andreas Färber
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 15/16] cpu/a15mpcore: Convert to QOM realize Andreas Färber
2013-07-23 2:43 ` [Qemu-devel] [PATCH v2 16/16] cpu/a15mpcore: Prepare for QOM embedding Andreas Färber
2013-07-23 19:15 ` [Qemu-devel] [PATCH v2 00/16] arm: A9MPCore+A15MPCore QOM'ification Peter Maydell
2013-07-23 21:16 ` Peter Maydell
2013-07-23 21:36 ` Alexander Graf
2013-07-23 21:52 ` Peter Maydell
2013-07-23 21:55 ` Alexander Graf
2013-07-23 22:12 ` Andreas Färber
2013-07-23 22:26 ` Peter Maydell
2013-07-23 22:08 ` Andreas Färber
2013-07-23 22:10 ` Peter Maydell
2013-07-23 22:18 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374547404-11700-13-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).