qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH v2 02/16] cpu/a9mpcore: Split off instance_init
Date: Tue, 23 Jul 2013 04:43:10 +0200	[thread overview]
Message-ID: <1374547404-11700-3-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1374547404-11700-1-git-send-email-afaerber@suse.de>

From: Andreas Färber <andreas.faerber@web.de>

Prepares for QOM realize.

Signed-off-by: Andreas Färber <andreas.faerber@web.de>
---
 hw/cpu/a9mpcore.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c
index 3e675e3..acbdab5 100644
--- a/hw/cpu/a9mpcore.c
+++ b/hw/cpu/a9mpcore.c
@@ -34,6 +34,14 @@ static void a9mp_priv_set_irq(void *opaque, int irq, int level)
     qemu_set_irq(qdev_get_gpio_in(s->gic, irq), level);
 }
 
+static void a9mp_priv_initfn(Object *obj)
+{
+    A9MPPrivState *s = A9MPCORE_PRIV(obj);
+
+    memory_region_init(&s->container, obj, "a9mp-priv-container", 0x2000);
+    sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->container);
+}
+
 static int a9mp_priv_init(SysBusDevice *dev)
 {
     A9MPPrivState *s = A9MPCORE_PRIV(dev);
@@ -78,7 +86,6 @@ static int a9mp_priv_init(SysBusDevice *dev)
      *
      * We should implement the global timer but don't currently do so.
      */
-    memory_region_init(&s->container, OBJECT(s), "a9mp-priv-container", 0x2000);
     memory_region_add_subregion(&s->container, 0,
                                 sysbus_mmio_get_region(scubusdev, 0));
     /* GIC CPU interface */
@@ -94,8 +101,6 @@ static int a9mp_priv_init(SysBusDevice *dev)
     memory_region_add_subregion(&s->container, 0x1000,
                                 sysbus_mmio_get_region(gicbusdev, 0));
 
-    sysbus_init_mmio(dev, &s->container);
-
     /* Wire up the interrupt from each watchdog and timer.
      * For each core the timer is PPI 29 and the watchdog PPI 30.
      */
@@ -134,6 +139,7 @@ static const TypeInfo a9mp_priv_info = {
     .name          = TYPE_A9MPCORE_PRIV,
     .parent        = TYPE_SYS_BUS_DEVICE,
     .instance_size = sizeof(A9MPPrivState),
+    .instance_init = a9mp_priv_initfn,
     .class_init    = a9mp_priv_class_init,
 };
 
-- 
1.8.1.4

  parent reply	other threads:[~2013-07-23  2:43 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  2:43 [Qemu-devel] [PATCH v2 00/16] arm: A9MPCore+A15MPCore QOM'ification Andreas Färber
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 01/16] cpu/a9mpcore: QOM casting cleanup Andreas Färber
2013-07-23 22:48   ` Peter Maydell
2013-07-23  2:43 ` Andreas Färber [this message]
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 03/16] intc/arm_gic: Extract public header hw/intc/arm_gic.h Andreas Färber
2013-07-25 15:40   ` Peter Maydell
2013-07-26 20:06   ` Andreas Färber
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 04/16] cpu/a9mpcore: Embed GICState Andreas Färber
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 05/16] misc/a9scu: QOM cleanups Andreas Färber
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 06/16] cpu/a9mpcore: Embed A9SCUState Andreas Färber
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 07/16] timer/arm_mptimer: QOM cast cleanup Andreas Färber
2013-07-23 22:50   ` Peter Maydell
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 08/16] timer/arm_mptimer: Convert to QOM realize Andreas Färber
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 09/16] cpu/a9mpcore: Embed ARMMPTimerState Andreas Färber
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 10/16] cpu/a9mpcore: Convert to QOM realize Andreas Färber
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 11/16] cpu/a9mpcore: Prepare for QOM embedding Andreas Färber
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 12/16] cpu/a15mpcore: QOM cast cleanup Andreas Färber
2013-07-23 22:49   ` Peter Maydell
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 13/16] cpu/a15mpcore: Split off instance_init Andreas Färber
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 14/16] cpu/a15mpcore: Embed GICState Andreas Färber
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 15/16] cpu/a15mpcore: Convert to QOM realize Andreas Färber
2013-07-23  2:43 ` [Qemu-devel] [PATCH v2 16/16] cpu/a15mpcore: Prepare for QOM embedding Andreas Färber
2013-07-23 19:15 ` [Qemu-devel] [PATCH v2 00/16] arm: A9MPCore+A15MPCore QOM'ification Peter Maydell
2013-07-23 21:16   ` Peter Maydell
2013-07-23 21:36     ` Alexander Graf
2013-07-23 21:52       ` Peter Maydell
2013-07-23 21:55         ` Alexander Graf
2013-07-23 22:12           ` Andreas Färber
2013-07-23 22:26             ` Peter Maydell
2013-07-23 22:08         ` Andreas Färber
2013-07-23 22:10           ` Peter Maydell
2013-07-23 22:18             ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374547404-11700-3-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=paul@codesourcery.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).