From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: vasilis.liaskovitis@profitbricks.com, hutao@cn.fujitsu.com,
pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 07/16] dimm: map DimmDevice into DimBus provided address space
Date: Tue, 23 Jul 2013 18:23:03 +0200 [thread overview]
Message-ID: <1374596592-7027-8-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1374596592-7027-1-git-send-email-imammedo@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/mem-hotplug/dimm.c | 14 ++++++++++++++
include/hw/mem-hotplug/dimm.h | 14 ++++++++++++++
2 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/hw/mem-hotplug/dimm.c b/hw/mem-hotplug/dimm.c
index 0a337a5..63c2c8e 100644
--- a/hw/mem-hotplug/dimm.c
+++ b/hw/mem-hotplug/dimm.c
@@ -27,14 +27,23 @@ static void dimm_bus_initfn(Object *obj)
b->allow_hotplug = true;
}
+static void dimm_bus_register_memory(DimmBus *bus, DimmDevice *dimm,
+ Error **errp)
+{
+ memory_region_add_subregion(&bus->as, dimm->start - bus->base, &dimm->mr);
+ vmstate_register_ram_global(&dimm->mr);
+}
+
static void dimm_bus_class_init(ObjectClass *klass, void *data)
{
BusClass *bc = BUS_CLASS(klass);
+ DimmBusClass *dc = DIMM_BUS_CLASS(klass);
QemuOpts *opts = qemu_opts_find(qemu_find_opts("memory-opts"), NULL);
if (opts) {
bc->max_dev = qemu_opt_get_number(opts, "slots", 0);
}
+ dc->register_memory = dimm_bus_register_memory;
}
static const TypeInfo dimm_bus_info = {
@@ -43,6 +52,7 @@ static const TypeInfo dimm_bus_info = {
.instance_init = dimm_bus_initfn,
.instance_size = sizeof(DimmBus),
.class_init = dimm_bus_class_init,
+ .class_size = sizeof(DimmBusClass),
};
static Property dimm_properties[] = {
@@ -58,6 +68,7 @@ static void dimm_realize(DeviceState *dev, Error **errp)
DimmDevice *dimm = DIMM(dev);
DimmBus *bus = DIMM_BUS(qdev_get_parent_bus(dev));
BusClass *bc = BUS_GET_CLASS(bus);
+ DimmBusClass *dc = DIMM_BUS_GET_CLASS(bus);
if (!dev->id) {
error_setg(errp, "missing 'id' property");
@@ -70,6 +81,9 @@ static void dimm_realize(DeviceState *dev, Error **errp)
}
memory_region_init_ram(&dimm->mr, dev->id, dimm->size);
+
+ g_assert(dc->register_memory);
+ dc->register_memory(bus, dimm, errp);
}
static void dimm_class_init(ObjectClass *klass, void *data)
diff --git a/include/hw/mem-hotplug/dimm.h b/include/hw/mem-hotplug/dimm.h
index c83ad26..84d6ba6 100644
--- a/include/hw/mem-hotplug/dimm.h
+++ b/include/hw/mem-hotplug/dimm.h
@@ -58,9 +58,23 @@ typedef struct DimmDeviceClass {
/**
* DimmBus:
+ * @base: address from which to start mapping @DimmDevice
+ * @as: hot-plugabble memory area where @DimmDevice-s are attached
*/
typedef struct DimmBus {
BusState qbus;
+ hwaddr base;
+ MemoryRegion as;
} DimmBus;
+/**
+ * DimmBusClass:
+ * @register_memory: map @DimmDevice into hot-plugable address space
+ */
+typedef struct DimmBusClass {
+ BusClass parent_class;
+
+ void (*register_memory)(DimmBus *bus, DimmDevice *dimm, Error **errp);
+} DimmBusClass;
+
#endif
--
1.7.1
next prev parent reply other threads:[~2013-07-23 16:24 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 16:22 [Qemu-devel] [PATCH 00/16 RFC v6] ACPI memory hotplug Igor Mammedov
2013-07-23 16:22 ` [Qemu-devel] [PATCH 01/16] pc: use pci_hole64 info consistently Igor Mammedov
2013-07-23 16:22 ` [Qemu-devel] [PATCH 02/16] vl: set default ram_size during variable initialization Igor Mammedov
2013-08-02 20:33 ` Andreas Färber
2013-09-09 14:06 ` Igor Mammedov
2013-09-09 14:31 ` Paolo Bonzini
2013-09-09 15:26 ` Igor Mammedov
2013-07-23 16:22 ` [Qemu-devel] [PATCH 03/16] vl: convert -m to qemu_opts_parse() Igor Mammedov
2013-07-23 17:11 ` Paolo Bonzini
2013-07-24 8:40 ` Igor Mammedov
2013-07-24 9:04 ` Paolo Bonzini
2013-07-24 9:27 ` Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 04/16] qapi: make visit_type_size fallback to type_int Igor Mammedov
2013-07-25 6:41 ` Hu Tao
2013-07-25 11:35 ` Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 05/16] qdev: Add SIZE type to qdev properties Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 06/16] dimm: implement dimm device abstraction Igor Mammedov
2013-07-25 6:52 ` Hu Tao
2013-07-23 16:23 ` Igor Mammedov [this message]
2013-07-23 16:23 ` [Qemu-devel] [PATCH 08/16] pc: piix: make hotplug memory gap in high memory Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 09/16] pc: i440fx: add DimmBus to chipset and map it into hotplug memory region Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation Igor Mammedov
2013-07-23 17:09 ` Paolo Bonzini
2013-07-24 8:36 ` Igor Mammedov
2013-07-24 9:41 ` Paolo Bonzini
2013-07-24 11:34 ` Igor Mammedov
2013-07-24 12:41 ` Paolo Bonzini
2013-07-26 7:38 ` Igor Mammedov
2013-07-26 9:26 ` Paolo Bonzini
2013-07-26 12:51 ` Igor Mammedov
2013-07-26 14:37 ` Paolo Bonzini
2013-08-03 13:56 ` Andreas Färber
2013-09-11 15:12 ` Igor Mammedov
2013-08-06 7:13 ` Markus Armbruster
2013-07-23 16:23 ` [Qemu-devel] [PATCH 11/16] dimm: add busy address check and address auto-allocation Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 12/16] dimm: introduce memory added notifier Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 13/16] acpi/piix4: introduce memory hot-plug interface QEMU<->ACPI BIOS Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 14/16] pc: ACPI BIOS: implement memory hotplug interface Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 15/16] pc: update acpi-dsdt.hex.generated and add ssdt-mem.hex.generated Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 16/16] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole Igor Mammedov
2013-07-24 9:52 ` [Qemu-devel] [PATCH 00/16 RFC v6] ACPI memory hotplug Hu Tao
2013-07-24 10:02 ` Igor Mammedov
2013-07-24 10:58 ` Vasilis Liaskovitis
2013-08-02 12:35 ` Anthony Liguori
2013-08-07 14:14 ` Erlon Cruz
2013-08-09 17:19 ` Anthony Liguori
2013-09-11 4:01 ` Hu Tao
2013-09-17 12:29 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374596592-7027-8-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vasilis.liaskovitis@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).