From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: vasilis.liaskovitis@profitbricks.com, hutao@cn.fujitsu.com,
pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 08/16] pc: piix: make hotplug memory gap in high memory
Date: Tue, 23 Jul 2013 18:23:04 +0200 [thread overview]
Message-ID: <1374596592-7027-9-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1374596592-7027-1-git-send-email-imammedo@redhat.com>
reserves memory region above 4Gb ram region and upto maxmem
before 64-bit PCI hole.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/pc.c | 10 +++++++++-
include/hw/i386/pc.h | 1 +
2 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 6e2c4d9..d3ccc79 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1054,8 +1054,12 @@ PcGuestInfo *pc_guest_info_init(ram_addr_t below_4g_mem_size,
{
PcGuestInfoState *guest_info_state = g_malloc0(sizeof *guest_info_state);
PcGuestInfo *guest_info = &guest_info_state->info;
+ QemuOpts *opts = qemu_opts_find(qemu_find_opts("memory-opts"), NULL);
+ ram_addr_t maxmem = (opts ? qemu_opt_get_size(opts, "maxmem", ram_size) :
+ ram_size);
guest_info->ram_size = below_4g_mem_size + above_4g_mem_size;
+
guest_info->apic_id_limit = pc_apic_id_limit(max_cpus);
guest_info->apic_xrupt_override = kvm_allows_irq0_override();
guest_info->numa_nodes = nb_numa_nodes;
@@ -1072,6 +1076,10 @@ PcGuestInfo *pc_guest_info_init(ram_addr_t below_4g_mem_size,
guest_info->pci_info.w64.begin = 0;
guest_info->pci_info.w64.end = 0;
} else {
+ guest_info->hotplug_mem_win.begin = ROUND_UP((0x1ULL << 32) +
+ above_4g_mem_size, 0x1ULL << 30);
+ guest_info->hotplug_mem_win.end = guest_info->hotplug_mem_win.begin +
+ (maxmem - guest_info->ram_size);
/*
* BIOS does not set MTRR entries for the 64 bit window, so no need to
* align address to power of two. Align address at 1G, this makes sure
@@ -1079,7 +1087,7 @@ PcGuestInfo *pc_guest_info_init(ram_addr_t below_4g_mem_size,
* pages.
*/
guest_info->pci_info.w64.begin =
- ROUND_UP((0x1ULL << 32) + above_4g_mem_size, 0x1ULL << 30);
+ ROUND_UP(guest_info->hotplug_mem_win.end, 0x1ULL << 30);
guest_info->pci_info.w64.end = guest_info->pci_info.w64.begin +
(0x1ULL << 31);
assert(guest_info->pci_info.w64.begin <= guest_info->pci_info.w64.end);
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 7574d92..388d803 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -28,6 +28,7 @@ struct PcGuestInfo {
PcPciInfo pci_info;
bool has_pci_info;
hwaddr ram_size;
+ Range hotplug_mem_win;
unsigned apic_id_limit;
bool apic_xrupt_override;
bool has_hpet;
--
1.7.1
next prev parent reply other threads:[~2013-07-23 16:24 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 16:22 [Qemu-devel] [PATCH 00/16 RFC v6] ACPI memory hotplug Igor Mammedov
2013-07-23 16:22 ` [Qemu-devel] [PATCH 01/16] pc: use pci_hole64 info consistently Igor Mammedov
2013-07-23 16:22 ` [Qemu-devel] [PATCH 02/16] vl: set default ram_size during variable initialization Igor Mammedov
2013-08-02 20:33 ` Andreas Färber
2013-09-09 14:06 ` Igor Mammedov
2013-09-09 14:31 ` Paolo Bonzini
2013-09-09 15:26 ` Igor Mammedov
2013-07-23 16:22 ` [Qemu-devel] [PATCH 03/16] vl: convert -m to qemu_opts_parse() Igor Mammedov
2013-07-23 17:11 ` Paolo Bonzini
2013-07-24 8:40 ` Igor Mammedov
2013-07-24 9:04 ` Paolo Bonzini
2013-07-24 9:27 ` Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 04/16] qapi: make visit_type_size fallback to type_int Igor Mammedov
2013-07-25 6:41 ` Hu Tao
2013-07-25 11:35 ` Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 05/16] qdev: Add SIZE type to qdev properties Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 06/16] dimm: implement dimm device abstraction Igor Mammedov
2013-07-25 6:52 ` Hu Tao
2013-07-23 16:23 ` [Qemu-devel] [PATCH 07/16] dimm: map DimmDevice into DimBus provided address space Igor Mammedov
2013-07-23 16:23 ` Igor Mammedov [this message]
2013-07-23 16:23 ` [Qemu-devel] [PATCH 09/16] pc: i440fx: add DimmBus to chipset and map it into hotplug memory region Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation Igor Mammedov
2013-07-23 17:09 ` Paolo Bonzini
2013-07-24 8:36 ` Igor Mammedov
2013-07-24 9:41 ` Paolo Bonzini
2013-07-24 11:34 ` Igor Mammedov
2013-07-24 12:41 ` Paolo Bonzini
2013-07-26 7:38 ` Igor Mammedov
2013-07-26 9:26 ` Paolo Bonzini
2013-07-26 12:51 ` Igor Mammedov
2013-07-26 14:37 ` Paolo Bonzini
2013-08-03 13:56 ` Andreas Färber
2013-09-11 15:12 ` Igor Mammedov
2013-08-06 7:13 ` Markus Armbruster
2013-07-23 16:23 ` [Qemu-devel] [PATCH 11/16] dimm: add busy address check and address auto-allocation Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 12/16] dimm: introduce memory added notifier Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 13/16] acpi/piix4: introduce memory hot-plug interface QEMU<->ACPI BIOS Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 14/16] pc: ACPI BIOS: implement memory hotplug interface Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 15/16] pc: update acpi-dsdt.hex.generated and add ssdt-mem.hex.generated Igor Mammedov
2013-07-23 16:23 ` [Qemu-devel] [PATCH 16/16] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole Igor Mammedov
2013-07-24 9:52 ` [Qemu-devel] [PATCH 00/16 RFC v6] ACPI memory hotplug Hu Tao
2013-07-24 10:02 ` Igor Mammedov
2013-07-24 10:58 ` Vasilis Liaskovitis
2013-08-02 12:35 ` Anthony Liguori
2013-08-07 14:14 ` Erlon Cruz
2013-08-09 17:19 ` Anthony Liguori
2013-09-11 4:01 ` Hu Tao
2013-09-17 12:29 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374596592-7027-9-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vasilis.liaskovitis@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).