From: Alex Bligh <alex@alex.org.uk>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Alex Bligh <alex@alex.org.uk>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
rth@twiddle.net
Subject: [Qemu-devel] [PATCHv2a] [RFC 8/7 (really)] Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack
Date: Wed, 24 Jul 2013 15:46:09 +0100 [thread overview]
Message-ID: <1374677169-25744-1-git-send-email-alex@alex.org.uk> (raw)
In-Reply-To: <51EF8851.4040209@redhat.com>
Where supported, called prctl(PR_SET_TIMERSLACK, 1, ...) to
set one nanosecond timer slack to increase precision of timer
calls.
Signed-off-by: Alex Bligh <alex@alex.org.uk>
---
[ Additional patch on the the end of the PATCHv2 series - I'll
resend if I have further comments with this reordered so it's
next to the ppoll introduction ]
configure | 18 ++++++++++++++++++
qemu-timer.c | 7 +++++++
2 files changed, 25 insertions(+)
diff --git a/configure b/configure
index b491c00..c8e39bc 100755
--- a/configure
+++ b/configure
@@ -2817,6 +2817,21 @@ if compile_prog "" "" ; then
ppoll=yes
fi
+# check for prctl(PR_SET_TIMERSLACK , ... ) support
+prctl_pr_set_timerslack=no
+cat > $TMPC << EOF
+#include <sys/prctl.h>
+
+int main(void)
+{
+ prctl(PR_SET_TIMERSLACK, 1, 0, 0, 0);
+ return 0;
+}
+EOF
+if compile_prog "" "" ; then
+ prctl_pr_set_timerslack=yes
+fi
+
# check for epoll support
epoll=no
cat > $TMPC << EOF
@@ -3811,6 +3826,9 @@ fi
if test "$ppoll" = "yes" ; then
echo "CONFIG_PPOLL=y" >> $config_host_mak
fi
+if test "$prctl_pr_set_timerslack" = "yes" ; then
+ echo "CONFIG_PRCTL_PR_SET_TIMERSLACK=y" >> $config_host_mak
+fi
if test "$epoll" = "yes" ; then
echo "CONFIG_EPOLL=y" >> $config_host_mak
fi
diff --git a/qemu-timer.c b/qemu-timer.c
index 4cba055..53cb62c 100644
--- a/qemu-timer.c
+++ b/qemu-timer.c
@@ -37,6 +37,10 @@
#include <poll.h>
#endif
+#ifdef CONFIG_PRCTL_PR_SET_TIMERSLACK
+#include <sys/prctl.h>
+#endif
+
/***********************************************************/
/* timers */
@@ -367,6 +371,9 @@ void init_clocks(void)
vm_clock = qemu_new_clock(QEMU_CLOCK_VIRTUAL);
host_clock = qemu_new_clock(QEMU_CLOCK_HOST);
}
+#ifdef CONFIG_PRCTL_PR_SET_TIMERSLACK
+ prctl(PR_SET_TIMERSLACK, 1, 0, 0, 0);
+#endif
}
uint64_t qemu_timer_expire_time_ns(QEMUTimer *ts)
--
1.7.9.5
next prev parent reply other threads:[~2013-07-24 14:46 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 8:42 [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff Liu Ping Fan
2013-07-21 8:42 ` [Qemu-devel] [RFC 1/8] timer: associate alarm_timer with AioContext Liu Ping Fan
2013-07-22 6:55 ` Jan Kiszka
2013-07-21 8:42 ` [Qemu-devel] [RFC 2/8] timer: pick out timer list info from QemuClock Liu Ping Fan
2013-07-21 8:43 ` [Qemu-devel] [RFC 3/8] timer: make timers_state static Liu Ping Fan
2013-07-22 6:36 ` Jan Kiszka
2013-07-22 17:40 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-07-21 8:43 ` [Qemu-devel] [RFC 4/8] timer: protect timers_state with lock Liu Ping Fan
2013-07-22 6:40 ` Jan Kiszka
2013-07-21 8:43 ` [Qemu-devel] [RFC 5/8] timer: associate timer with AioContext Liu Ping Fan
2013-07-21 8:43 ` [Qemu-devel] [RFC 6/8] timer: run timers on aio_poll Liu Ping Fan
2013-07-21 9:55 ` Alex Bligh
2013-07-23 2:56 ` liu ping fan
2013-07-23 14:22 ` Alex Bligh
2013-07-21 8:43 ` [Qemu-devel] [RFC 7/8] block: associate BlockDriverState with AioContext Liu Ping Fan
2013-07-21 8:43 ` [Qemu-devel] [RFC 8/8] block: enable throttle with aiocontext Liu Ping Fan
2013-07-21 9:53 ` [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff Alex Bligh
2013-07-22 4:38 ` liu ping fan
2013-07-22 6:28 ` Jan Kiszka
2013-07-23 2:51 ` liu ping fan
2013-07-25 11:44 ` Stefan Hajnoczi
2013-07-25 12:01 ` Jan Kiszka
2013-07-22 9:40 ` Alex Bligh
2013-07-22 10:18 ` liu ping fan
2013-07-23 2:53 ` liu ping fan
2013-07-23 10:30 ` Paolo Bonzini
2013-07-24 1:28 ` liu ping fan
2013-07-24 6:42 ` Paolo Bonzini
2013-07-24 7:31 ` Alex Bligh
2013-07-24 7:43 ` Paolo Bonzini
2013-07-24 8:01 ` Alex Bligh
2013-07-24 8:19 ` Paolo Bonzini
2013-07-24 8:37 ` Alex Bligh
2013-07-24 11:28 ` Paolo Bonzini
2013-07-24 8:30 ` liu ping fan
2013-07-24 7:43 ` liu ping fan
2013-07-24 7:54 ` Paolo Bonzini
2013-07-24 8:06 ` Alex Bligh
2013-07-24 14:46 ` Alex Bligh [this message]
2013-07-23 14:21 ` Alex Bligh
2013-07-25 11:47 ` Stefan Hajnoczi
2013-07-25 12:05 ` Stefan Hajnoczi
2013-07-25 12:21 ` Alex Bligh
2013-07-25 12:32 ` Jan Kiszka
2013-07-25 12:35 ` Paolo Bonzini
2013-07-25 12:38 ` Jan Kiszka
2013-07-25 12:41 ` Stefan Hajnoczi
2013-07-25 12:48 ` Jan Kiszka
2013-07-25 13:02 ` Paolo Bonzini
2013-07-25 13:06 ` Jan Kiszka
2013-07-25 13:31 ` Stefan Hajnoczi
2013-07-25 14:01 ` Jan Kiszka
2013-07-25 12:59 ` Paolo Bonzini
2013-07-25 18:53 ` Alex Bligh
2013-07-26 8:43 ` Stefan Hajnoczi
2013-07-26 9:08 ` Alex Bligh
2013-07-26 9:19 ` Paolo Bonzini
2013-07-29 8:58 ` Kevin Wolf
2013-07-29 10:22 ` Alex Bligh
2013-07-29 10:45 ` Paolo Bonzini
2013-07-31 9:02 ` Stefan Hajnoczi
2013-07-26 10:05 ` Jan Kiszka
2013-07-26 19:29 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374677169-25744-1-git-send-email-alex@alex.org.uk \
--to=alex@alex.org.uk \
--cc=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).