qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Maksim Kozlov" <m.kozlov@samsung.com>,
	"Igor Mitsyanko" <i.mitsyanko@samsung.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Evgeny Voevodin" <e.voevodin@samsung.com>,
	"Dmitry Solodkiy" <d.solodkiy@samsung.com>
Subject: [Qemu-devel] [PATCH qom-next for-1.6 04/14] exynos4210_uart: QOM'ify
Date: Wed, 24 Jul 2013 23:42:09 +0200	[thread overview]
Message-ID: <1374702140-13771-5-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1374702140-13771-1-git-send-email-afaerber@suse.de>

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 hw/char/exynos4210_uart.c | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c
index 855ce7a..eef23a0 100644
--- a/hw/char/exynos4210_uart.c
+++ b/hw/char/exynos4210_uart.c
@@ -166,8 +166,13 @@ typedef struct {
     uint32_t    size;
 } Exynos4210UartFIFO;
 
-typedef struct {
-    SysBusDevice busdev;
+#define TYPE_EXYNOS4210_UART "exynos4210.uart"
+#define EXYNOS4210_UART(obj) \
+    OBJECT_CHECK(Exynos4210UartState, (obj), TYPE_EXYNOS4210_UART)
+
+typedef struct Exynos4210UartState {
+    SysBusDevice parent_obj;
+
     MemoryRegion iomem;
 
     uint32_t             reg[EXYNOS4210_UART_REGS_MEM_SIZE / sizeof(uint32_t)];
@@ -538,8 +543,7 @@ static void exynos4210_uart_event(void *opaque, int event)
 
 static void exynos4210_uart_reset(DeviceState *dev)
 {
-    Exynos4210UartState *s =
-            container_of(dev, Exynos4210UartState, busdev.qdev);
+    Exynos4210UartState *s = EXYNOS4210_UART(dev);
     int regs_number = sizeof(exynos4210_uart_regs)/sizeof(Exynos4210UartReg);
     int i;
 
@@ -582,10 +586,10 @@ static const VMStateDescription vmstate_exynos4210_uart = {
 };
 
 DeviceState *exynos4210_uart_create(hwaddr addr,
-                                 int fifo_size,
-                                 int channel,
-                                 CharDriverState *chr,
-                                 qemu_irq irq)
+                                    int fifo_size,
+                                    int channel,
+                                    CharDriverState *chr,
+                                    qemu_irq irq)
 {
     DeviceState  *dev;
     SysBusDevice *bus;
@@ -593,7 +597,7 @@ DeviceState *exynos4210_uart_create(hwaddr addr,
     const char chr_name[] = "serial";
     char label[ARRAY_SIZE(chr_name) + 1];
 
-    dev = qdev_create(NULL, "exynos4210.uart");
+    dev = qdev_create(NULL, TYPE_EXYNOS4210_UART);
 
     if (!chr) {
         if (channel >= MAX_SERIAL_PORTS) {
@@ -627,7 +631,7 @@ DeviceState *exynos4210_uart_create(hwaddr addr,
 
 static int exynos4210_uart_init(SysBusDevice *dev)
 {
-    Exynos4210UartState *s = FROM_SYSBUS(Exynos4210UartState, dev);
+    Exynos4210UartState *s = EXYNOS4210_UART(dev);
 
     /* memory mapping */
     memory_region_init_io(&s->iomem, OBJECT(s), &exynos4210_uart_ops, s,
@@ -662,7 +666,7 @@ static void exynos4210_uart_class_init(ObjectClass *klass, void *data)
 }
 
 static const TypeInfo exynos4210_uart_info = {
-    .name          = "exynos4210.uart",
+    .name          = TYPE_EXYNOS4210_UART,
     .parent        = TYPE_SYS_BUS_DEVICE,
     .instance_size = sizeof(Exynos4210UartState),
     .class_init    = exynos4210_uart_class_init,
-- 
1.8.1.4

  parent reply	other threads:[~2013-07-24 21:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24 21:42 [Qemu-devel] [PATCH qom-next for-1.6 00/14] char: QOM cast cleanups Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 01/14] cadence_uart: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 02/14] escc: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 03/14] etraxfs_ser: QOM'ify Andreas Färber
2013-07-26  3:04   ` Edgar E. Iglesias
2013-07-24 21:42 ` Andreas Färber [this message]
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 05/14] grlib_apbuart: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 06/14] imx_serial: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 07/14] lm32_juart: Relocate and tidy header Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 08/14] lm32_juart: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 09/14] lm32_uart: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 10/14] milkymist-uart: QOM'ify Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 11/14] pl011: Rename pl011_state Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 12/14] pl011: QOM'ify pl011 and pl011_luminary Andreas Färber
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 13/14] xilinx_uartlite: Rename xlx_uartlite to XilinxUARTLite Andreas Färber
2013-07-26  3:05   ` Edgar E. Iglesias
2013-07-24 21:42 ` [Qemu-devel] [PATCH qom-next for-1.6 14/14] xilinx_uartlite: QOM'ify Andreas Färber
2013-07-26  3:05   ` Edgar E. Iglesias
2013-07-26 22:28 ` [Qemu-devel] [PATCH qom-next for-1.6 00/14] char: QOM cast cleanups Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374702140-13771-5-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=d.solodkiy@samsung.com \
    --cc=e.voevodin@samsung.com \
    --cc=i.mitsyanko@samsung.com \
    --cc=m.kozlov@samsung.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).