From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pl@kamp.de, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/19] Add qemu-img subcommand to dump file metadata
Date: Thu, 25 Jul 2013 16:22:58 +0200 [thread overview]
Message-ID: <1374762197-7261-1-git-send-email-pbonzini@redhat.com> (raw)
This series adds a subcommand to "map" that can dump file metadata.
Metadata that is dumped includes:
- whether blocks are allocated in bs->file and, if so, where
- whether blocks are zero
- whether data is read from bs or bs->backing_hd
Metadata is dumped for an entire chain of images. One example usage is
(for non-compressed, non-encrypted images) to transform the metadata
into a Linux device-mapper setup, and make a qcow2 image available (for
read only) as a block device. Another possible usage is to determine
the used areas of a file, and convert it in place to another format.
Alternatively, the richer data can be used by block jobs to quickly
determine if a block is zero without reading it.
The patches implement a new operation, bdrv_co_get_block_status, that
supersedes bdrv_co_is_allocated. The bdrv_is_allocated API is still
available of course, and implemented on top of the new operation.
Patches 1-3 touch cow, which uses bdrv_co_is_allocated during its reads
and writes. I optimized it a bit because it was unbearably slow during
testing. With these patches (also tested with blkverify), booting of
a cow guest image is not particularly slow.
Patch 4 fixes the bs->total_sectors file size cache, which is used in
bdrv_co_get_block_status to clamp invalid input.
Patches 5 to 7 clean up the bdrv_is_allocated and bdrv_is_allocated_above
implementation, eliminating some code duplication.
Patches 8 and 9 tweak bdrv_has_zero_init and its usage in qemu-img in
a way that helps when implementing the new API.
Patches 10 to 12 implement bdrv_get_block_status and change the formats
to report all the available information.
Patch 13 and 14 adds the "map" subcommand to qemu-img, and the relevant
documentation.
Finally, patches 15 to 19 tweak the implementation to extract more
information from protocols, and combine this information with format
metadata whenever possible.
v2->v3:
new patch 4 to fix qemu-iotests regression
new patch 14 for documentation
Paolo Bonzini (19):
cow: make reads go at a decent speed
cow: make writes go at a less indecent speed
cow: do not call bdrv_co_is_allocated
block: update bs->total_sectors on writes
block: make bdrv_co_is_allocated static
block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above
distinction
block: expect errors from bdrv_co_is_allocated
qemu-img: always probe the input image for allocated sectors
block: make bdrv_has_zero_init return false for copy-on-write-images
block: introduce bdrv_get_block_status API
block: define get_block_status return value
block: return get_block_status data and flags for formats
qemu-img: add a "map" subcommand
docs, qapi: document qemu-img map
block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO
raw-posix: return get_block_status data and flags
raw-posix: detect XFS unwritten extents
block: add default get_block_status implementation for protocols
block: look for zero blocks in bs->file
block.c | 140 ++++++++++++++--------------
block/commit.c | 6 +-
block/cow.c | 90 ++++++++++++------
block/mirror.c | 4 +-
block/qcow.c | 13 ++-
block/qcow2.c | 24 +++--
block/qed.c | 39 ++++++--
block/raw-posix.c | 24 +++--
block/raw.c | 6 +-
block/sheepdog.c | 14 +--
block/stream.c | 10 +-
block/vdi.c | 17 +++-
block/vmdk.c | 23 ++++-
block/vvfat.c | 15 +--
include/block/block.h | 34 +++++--
include/block/block_int.h | 2 +-
qapi-schema.json | 29 ++++++
qemu-img-cmds.hx | 6 ++
qemu-img.c | 226 +++++++++++++++++++++++++++++++++++++++++-----
qemu-img.texi | 46 ++++++++++
20 files changed, 585 insertions(+), 183 deletions(-)
--
1.8.3.1
next reply other threads:[~2013-07-25 14:23 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 14:22 Paolo Bonzini [this message]
2013-07-25 14:22 ` [Qemu-devel] [PATCH v3 01/19] cow: make reads go at a decent speed Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 02/19] cow: make writes go at a less indecent speed Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 03/19] cow: do not call bdrv_co_is_allocated Paolo Bonzini
2013-07-29 13:22 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 04/19] block: update bs->total_sectors on writes Paolo Bonzini
2013-07-29 13:13 ` Kevin Wolf
2013-07-29 13:47 ` Paolo Bonzini
2013-07-29 14:10 ` Kevin Wolf
2013-07-29 14:18 ` Paolo Bonzini
2013-08-02 7:05 ` Peter Lieven
2013-08-17 6:27 ` Paolo Bonzini
2013-09-02 7:12 ` Peter Lieven
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 05/19] block: make bdrv_co_is_allocated static Paolo Bonzini
2013-07-29 13:21 ` Kevin Wolf
2013-07-29 13:56 ` Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 06/19] block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above distinction Paolo Bonzini
2013-07-29 13:34 ` Kevin Wolf
2013-07-29 13:59 ` Paolo Bonzini
2013-07-29 14:15 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 07/19] block: expect errors from bdrv_co_is_allocated Paolo Bonzini
2013-07-29 13:43 ` Kevin Wolf
2013-07-29 14:03 ` Paolo Bonzini
2013-07-29 14:17 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 08/19] qemu-img: always probe the input image for allocated sectors Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 09/19] block: make bdrv_has_zero_init return false for copy-on-write-images Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 10/19] block: introduce bdrv_get_block_status API Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 11/19] block: define get_block_status return value Paolo Bonzini
2013-07-30 14:14 ` Kevin Wolf
2013-07-30 14:19 ` Paolo Bonzini
2013-07-30 14:26 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 12/19] block: return get_block_status data and flags for formats Paolo Bonzini
2013-07-30 14:40 ` Kevin Wolf
2013-07-30 15:15 ` Paolo Bonzini
2013-07-30 15:23 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 13/19] qemu-img: add a "map" subcommand Paolo Bonzini
2013-07-30 15:13 ` Kevin Wolf
2013-07-30 15:22 ` Paolo Bonzini
2013-07-30 15:30 ` Kevin Wolf
2013-07-31 8:57 ` Kevin Wolf
2013-07-31 12:13 ` Paolo Bonzini
2013-07-31 13:26 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 14/19] docs, qapi: document qemu-img map Paolo Bonzini
2013-07-30 15:48 ` Eric Blake
2013-07-30 15:54 ` Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 15/19] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO Paolo Bonzini
2013-07-31 9:16 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 16/19] raw-posix: return get_block_status data and flags Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 17/19] raw-posix: detect XFS unwritten extents Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 18/19] block: add default get_block_status implementation for protocols Paolo Bonzini
2013-07-31 9:12 ` Kevin Wolf
2013-07-31 12:49 ` Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 19/19] block: look for zero blocks in bs->file Paolo Bonzini
2013-07-31 9:21 ` Kevin Wolf
2013-07-31 12:53 ` Paolo Bonzini
2013-08-16 15:30 ` [Qemu-devel] [PATCH v3 00/19] Add qemu-img subcommand to dump file metadata Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374762197-7261-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).