From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: pmatouse@redhat.com, aliguori@us.ibm.com, lersek@redhat.com,
qemu-stable@nongnu.org, lveyde@redhat.com
Subject: [Qemu-devel] [PATCH 1/3] qga/service-win32.c: diagnostic output should go to stderr
Date: Thu, 25 Jul 2013 15:37:22 -0500 [thread overview]
Message-ID: <1374784644-29078-2-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1374784644-29078-1-git-send-email-mdroth@linux.vnet.ibm.com>
From: Laszlo Ersek <lersek@redhat.com>
Acked-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
qga/service-win32.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qga/service-win32.c b/qga/service-win32.c
index 02926ab..6de8be4 100644
--- a/qga/service-win32.c
+++ b/qga/service-win32.c
@@ -29,7 +29,7 @@ static int printf_win_error(const char *text)
MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
(char *)&message, 0,
NULL);
- n = printf("%s. (Error: %d) %s", text, (int)err, message);
+ n = fprintf(stderr, "%s. (Error: %d) %s", text, (int)err, message);
LocalFree(message);
return n;
@@ -78,7 +78,7 @@ int ga_install_service(const char *path, const char *logfile,
SERVICE_DESCRIPTION desc = { (char *)QGA_SERVICE_DESCRIPTION };
ChangeServiceConfig2(service, SERVICE_CONFIG_DESCRIPTION, &desc);
- printf("Service was installed successfully.\n");
+ fprintf(stderr, "Service was installed successfully.\n");
} else {
printf_win_error("Failed to install service");
}
@@ -111,7 +111,7 @@ int ga_uninstall_service(void)
if (DeleteService(service) == FALSE) {
printf_win_error("Failed to delete service");
} else {
- printf("Service was deleted successfully.\n");
+ fprintf(stderr, "Service was deleted successfully.\n");
}
CloseServiceHandle(service);
--
1.7.9.5
next prev parent reply other threads:[~2013-07-25 20:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 20:37 [Qemu-devel] [PULL 0/3] qemu-ga: security fixes for CVE-2013-2231 Michael Roth
2013-07-25 20:37 ` Michael Roth [this message]
2013-07-25 20:37 ` [Qemu-devel] [PATCH 2/3] ga_install_service(): nest error paths more idiomatically Michael Roth
2013-07-25 20:37 ` [Qemu-devel] [PATCH 3/3] qga: escape cmdline args when registering win32 service (CVE-2013-2231) Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374784644-29078-2-git-send-email-mdroth@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=lersek@redhat.com \
--cc=lveyde@redhat.com \
--cc=pmatouse@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).