qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, lilei@linux.vnet.ibm.com,
	lcapitulino@redhat.com, kraxel@redhat.com, akong@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/3] qemu-char: ringbuf fixes
Date: Fri, 26 Jul 2013 16:44:31 +0200	[thread overview]
Message-ID: <1374849874-25531-1-git-send-email-armbru@redhat.com> (raw)

Fix code to match documentation.  The patches take pains to preserve
command-line, HMP and QMP bug-compatibility.  I'm not sure that's
actually needed, because:

* All: the documented way to use the driver never worked in any
  released version, and the way that worked was undocumented.

* QMP: I doubt anyone used chardev-add / chardev-remove in anger,
  because serious use surely would've run into the bug fixed in commit
  commit 2ea3e2c "qemu-char: Fix ID reuse after chardev-remove for
  qapi-based init".

I include the compatibility gunk anyway, so we can have a more
informed discussion.

You might want to apply this after my "Our QAPI parser is a hack,
replace it" series, so the indented comment in PATCH 3/3 works by
design rather than accident.

v2: Trivially rebased

Markus Armbruster (3):
  Revert "chardev: Make the name of memory device consistent"
  qemu-char: Register ring buffer driver with correct name "ringbuf"
  qapi: Rename ChardevBackend member "memory" to "ringbuf"

 qapi-schema.json | 12 +++++++-----
 qemu-char.c      | 26 +++++++++++++++-----------
 qemu-options.hx  |  6 +++---
 3 files changed, 25 insertions(+), 19 deletions(-)

-- 
1.7.11.7

             reply	other threads:[~2013-07-26 14:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26 14:44 Markus Armbruster [this message]
2013-07-26 14:44 ` [Qemu-devel] [PATCH v2 1/3] Revert "chardev: Make the name of memory device consistent" Markus Armbruster
2013-07-26 14:44 ` [Qemu-devel] [PATCH v2 2/3] qemu-char: Register ring buffer driver with correct name "ringbuf" Markus Armbruster
2013-07-26 14:44 ` [Qemu-devel] [PATCH v2 3/3] qapi: Rename ChardevBackend member "memory" to "ringbuf" Markus Armbruster
2013-07-26 15:06 ` [Qemu-devel] [PATCH v2 0/3] qemu-char: ringbuf fixes Eric Blake
2013-07-29 20:24 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374849874-25531-1-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=akong@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=kraxel@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=lilei@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).