From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Maksim Kozlov" <m.kozlov@samsung.com>,
"Igor Mitsyanko" <i.mitsyanko@samsung.com>,
"Andreas Färber" <afaerber@suse.de>,
"Evgeny Voevodin" <e.voevodin@samsung.com>,
"Dmitry Solodkiy" <d.solodkiy@samsung.com>
Subject: [Qemu-devel] [PATCH qom-next for-1.6 03/15] exynos4210_combiner: QOM cast cleanup
Date: Fri, 26 Jul 2013 20:54:02 +0200 [thread overview]
Message-ID: <1374864854-32454-4-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1374864854-32454-1-git-send-email-afaerber@suse.de>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
hw/intc/exynos4210_combiner.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c
index 3b40976..ef5e8eb 100644
--- a/hw/intc/exynos4210_combiner.c
+++ b/hw/intc/exynos4210_combiner.c
@@ -56,8 +56,13 @@ typedef struct CombinerGroupState {
uint8_t src_pending; /* Pending source interrupts before masking */
} CombinerGroupState;
+#define TYPE_EXYNOS4210_COMBINER "exynos4210.combiner"
+#define EXYNOS4210_COMBINER(obj) \
+ OBJECT_CHECK(Exynos4210CombinerState, (obj), TYPE_EXYNOS4210_COMBINER)
+
typedef struct Exynos4210CombinerState {
- SysBusDevice busdev;
+ SysBusDevice parent_obj;
+
MemoryRegion iomem;
struct CombinerGroupState group[IIC_NGRP];
@@ -402,24 +407,24 @@ static const MemoryRegionOps exynos4210_combiner_ops = {
/*
* Internal Combiner initialization.
*/
-static int exynos4210_combiner_init(SysBusDevice *dev)
+static int exynos4210_combiner_init(SysBusDevice *sbd)
{
+ DeviceState *dev = DEVICE(sbd);
+ Exynos4210CombinerState *s = EXYNOS4210_COMBINER(dev);
unsigned int i;
- struct Exynos4210CombinerState *s =
- FROM_SYSBUS(struct Exynos4210CombinerState, dev);
/* Allocate general purpose input signals and connect a handler to each of
* them */
- qdev_init_gpio_in(&s->busdev.qdev, exynos4210_combiner_handler, IIC_NIRQ);
+ qdev_init_gpio_in(dev, exynos4210_combiner_handler, IIC_NIRQ);
/* Connect SysBusDev irqs to device specific irqs */
for (i = 0; i < IIC_NIRQ; i++) {
- sysbus_init_irq(dev, &s->output_irq[i]);
+ sysbus_init_irq(sbd, &s->output_irq[i]);
}
memory_region_init_io(&s->iomem, OBJECT(s), &exynos4210_combiner_ops, s,
- "exynos4210-combiner", IIC_REGION_SIZE);
- sysbus_init_mmio(dev, &s->iomem);
+ "exynos4210-combiner", IIC_REGION_SIZE);
+ sysbus_init_mmio(sbd, &s->iomem);
return 0;
}
@@ -441,7 +446,7 @@ static void exynos4210_combiner_class_init(ObjectClass *klass, void *data)
}
static const TypeInfo exynos4210_combiner_info = {
- .name = "exynos4210.combiner",
+ .name = TYPE_EXYNOS4210_COMBINER,
.parent = TYPE_SYS_BUS_DEVICE,
.instance_size = sizeof(Exynos4210CombinerState),
.class_init = exynos4210_combiner_class_init,
--
1.8.1.4
next prev parent reply other threads:[~2013-07-26 18:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 18:53 [Qemu-devel] [PATCH qom-next for-1.6 00/15] intc: QOM cast cleanups Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 01/15] arm_gic: QOM cast cleanup Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 02/15] etraxfs_pic: " Andreas Färber
2013-07-26 18:54 ` Andreas Färber [this message]
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 04/15] exynos4210_gic: QOM cast cleanup for exynos4210.gic Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 05/15] exynos4210_gic: QOM cast cleanup for exynos4210.irq_gate Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 06/15] grlib_irqmp: QOM cast cleanup Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 07/15] imx_avic: " Andreas Färber
2013-07-28 23:29 ` Peter Chubb
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 08/15] lm32_pic: " Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 09/15] omap_intc: QOM'ify omap-intc and omap2-intc Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 10/15] pl190: Rename pl190_state to PL190State Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 11/15] pl190: QOM cast cleanup Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 12/15] puv3_intc: " Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 13/15] realview_gic: " Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 14/15] slavio_intctl: " Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 15/15] xilinx_intc: " Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374864854-32454-4-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=i.mitsyanko@samsung.com \
--cc=m.kozlov@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).