qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Peter Chubb" <peter.chubb@nicta.com.au>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH qom-next for-1.6 07/15] imx_avic: QOM cast cleanup
Date: Fri, 26 Jul 2013 20:54:06 +0200	[thread overview]
Message-ID: <1374864854-32454-8-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1374864854-32454-1-git-send-email-afaerber@suse.de>

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 hw/intc/imx_avic.c | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

diff --git a/hw/intc/imx_avic.c b/hw/intc/imx_avic.c
index 75c8ffd..fb00e91 100644
--- a/hw/intc/imx_avic.c
+++ b/hw/intc/imx_avic.c
@@ -55,8 +55,13 @@ do { printf("imx_avic: " fmt , ##args); } while (0)
 #define PRIO_PER_WORD (sizeof(uint32_t) * 8 / 4)
 #define PRIO_WORDS (IMX_AVIC_NUM_IRQS/PRIO_PER_WORD)
 
-typedef struct {
-    SysBusDevice busdev;
+#define TYPE_IMX_AVIC "imx_avic"
+#define IMX_AVIC(obj) \
+    OBJECT_CHECK(IMXAVICState, (obj), TYPE_IMX_AVIC)
+
+typedef struct IMXAVICState {
+    SysBusDevice parent_obj;
+
     MemoryRegion iomem;
     uint64_t pending;
     uint64_t enabled;
@@ -359,7 +364,8 @@ static const MemoryRegionOps imx_avic_ops = {
 
 static void imx_avic_reset(DeviceState *dev)
 {
-    IMXAVICState *s = container_of(dev, IMXAVICState, busdev.qdev);
+    IMXAVICState *s = IMX_AVIC(dev);
+
     s->pending = 0;
     s->enabled = 0;
     s->is_fiq = 0;
@@ -368,17 +374,18 @@ static void imx_avic_reset(DeviceState *dev)
     memset(s->prio, 0, sizeof s->prio);
 }
 
-static int imx_avic_init(SysBusDevice *dev)
+static int imx_avic_init(SysBusDevice *sbd)
 {
-    IMXAVICState *s = FROM_SYSBUS(IMXAVICState, dev);
+    DeviceState *dev = DEVICE(sbd);
+    IMXAVICState *s = IMX_AVIC(dev);
 
     memory_region_init_io(&s->iomem, OBJECT(s), &imx_avic_ops, s,
                           "imx_avic", 0x1000);
-    sysbus_init_mmio(dev, &s->iomem);
+    sysbus_init_mmio(sbd, &s->iomem);
 
-    qdev_init_gpio_in(&dev->qdev, imx_avic_set_irq, IMX_AVIC_NUM_IRQS);
-    sysbus_init_irq(dev, &s->irq);
-    sysbus_init_irq(dev, &s->fiq);
+    qdev_init_gpio_in(dev, imx_avic_set_irq, IMX_AVIC_NUM_IRQS);
+    sysbus_init_irq(sbd, &s->irq);
+    sysbus_init_irq(sbd, &s->fiq);
 
     return 0;
 }
@@ -395,7 +402,7 @@ static void imx_avic_class_init(ObjectClass *klass, void *data)
 }
 
 static const TypeInfo imx_avic_info = {
-    .name = "imx_avic",
+    .name = TYPE_IMX_AVIC,
     .parent = TYPE_SYS_BUS_DEVICE,
     .instance_size = sizeof(IMXAVICState),
     .class_init = imx_avic_class_init,
-- 
1.8.1.4

  parent reply	other threads:[~2013-07-26 18:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26 18:53 [Qemu-devel] [PATCH qom-next for-1.6 00/15] intc: QOM cast cleanups Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 01/15] arm_gic: QOM cast cleanup Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 02/15] etraxfs_pic: " Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 03/15] exynos4210_combiner: " Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 04/15] exynos4210_gic: QOM cast cleanup for exynos4210.gic Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 05/15] exynos4210_gic: QOM cast cleanup for exynos4210.irq_gate Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 06/15] grlib_irqmp: QOM cast cleanup Andreas Färber
2013-07-26 18:54 ` Andreas Färber [this message]
2013-07-28 23:29   ` [Qemu-devel] [PATCH qom-next for-1.6 07/15] imx_avic: " Peter Chubb
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 08/15] lm32_pic: " Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 09/15] omap_intc: QOM'ify omap-intc and omap2-intc Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 10/15] pl190: Rename pl190_state to PL190State Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 11/15] pl190: QOM cast cleanup Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 12/15] puv3_intc: " Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 13/15] realview_gic: " Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 14/15] slavio_intctl: " Andreas Färber
2013-07-26 18:54 ` [Qemu-devel] [PATCH qom-next for-1.6 15/15] xilinx_intc: " Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374864854-32454-8-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=peter.chubb@nicta.com.au \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).