qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH qom-next for-1.6 03/14] arm_sysctl: QOM cast cleanup
Date: Fri, 26 Jul 2013 23:34:03 +0200	[thread overview]
Message-ID: <1374874454-15549-4-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1374874454-15549-1-git-send-email-afaerber@suse.de>

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 hw/misc/arm_sysctl.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/hw/misc/arm_sysctl.c b/hw/misc/arm_sysctl.c
index 5906ae5..4a911d4 100644
--- a/hw/misc/arm_sysctl.c
+++ b/hw/misc/arm_sysctl.c
@@ -16,8 +16,13 @@
 
 #define LOCK_VALUE 0xa05f
 
+#define TYPE_ARM_SYSCTL "realview_sysctl"
+#define ARM_SYSCTL(obj) \
+    OBJECT_CHECK(arm_sysctl_state, (obj), TYPE_ARM_SYSCTL)
+
 typedef struct {
-    SysBusDevice busdev;
+    SysBusDevice parent_obj;
+
     MemoryRegion iomem;
     qemu_irq pl110_mux_ctrl;
 
@@ -85,7 +90,7 @@ static int board_id(arm_sysctl_state *s)
 
 static void arm_sysctl_reset(DeviceState *d)
 {
-    arm_sysctl_state *s = FROM_SYSBUS(arm_sysctl_state, SYS_BUS_DEVICE(d));
+    arm_sysctl_state *s = ARM_SYSCTL(d);
     int i;
 
     s->leds = 0;
@@ -587,7 +592,7 @@ static void arm_sysctl_init(Object *obj)
 {
     DeviceState *dev = DEVICE(obj);
     SysBusDevice *sd = SYS_BUS_DEVICE(obj);
-    arm_sysctl_state *s = FROM_SYSBUS(arm_sysctl_state, sd);
+    arm_sysctl_state *s = ARM_SYSCTL(obj);
 
     memory_region_init_io(&s->iomem, OBJECT(dev), &arm_sysctl_ops, s,
                           "arm-sysctl", 0x1000);
@@ -598,14 +603,15 @@ static void arm_sysctl_init(Object *obj)
 
 static void arm_sysctl_realize(DeviceState *d, Error **errp)
 {
-    arm_sysctl_state *s = FROM_SYSBUS(arm_sysctl_state, SYS_BUS_DEVICE(d));
+    arm_sysctl_state *s = ARM_SYSCTL(d);
+
     s->db_clock = g_new0(uint32_t, s->db_num_clocks);
 }
 
 static void arm_sysctl_finalize(Object *obj)
 {
-    SysBusDevice *dev = SYS_BUS_DEVICE(obj);
-    arm_sysctl_state *s = FROM_SYSBUS(arm_sysctl_state, dev);
+    arm_sysctl_state *s = ARM_SYSCTL(obj);
+
     g_free(s->db_voltage);
     g_free(s->db_clock);
     g_free(s->db_clock_reset);
@@ -634,7 +640,7 @@ static void arm_sysctl_class_init(ObjectClass *klass, void *data)
 }
 
 static const TypeInfo arm_sysctl_info = {
-    .name          = "realview_sysctl",
+    .name          = TYPE_ARM_SYSCTL,
     .parent        = TYPE_SYS_BUS_DEVICE,
     .instance_size = sizeof(arm_sysctl_state),
     .instance_init = arm_sysctl_init,
-- 
1.8.1.4

  parent reply	other threads:[~2013-07-26 21:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26 21:34 [Qemu-devel] [PATCH qom-next for-1.6 00/14] misc: QOM cast cleanups Andreas Färber
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 01/14] arm_l2x0: Rename l2x0_state to L2x0State Andreas Färber
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 02/14] arm_l2x0: QOM cast cleanup Andreas Färber
2013-07-26 21:34 ` Andreas Färber [this message]
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 04/14] eccmemctl: " Andreas Färber
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 05/14] exynos4210_pmu: " Andreas Färber
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 06/14] imx_ccm: " Andreas Färber
2013-07-28 23:34   ` Peter Chubb
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 07/14] lm32_sys: " Andreas Färber
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 08/14] milkymist-hpdmc: " Andreas Färber
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 09/14] milkymist-pfpu: " Andreas Färber
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 10/14] mst_fpga: " Andreas Färber
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 11/14] puv3_pm: " Andreas Färber
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 12/14] slavio_misc: QOM cast cleanup for MiscState Andreas Färber
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 13/14] slavio_misc: QOM cast cleanup for APCState Andreas Färber
2013-07-26 21:34 ` [Qemu-devel] [PATCH qom-next for-1.6 14/14] zynq_slcr: QOM cast cleanup Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374874454-15549-4-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).