From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <Laurent@vivier.eu>,
patches@linaro.org
Subject: [Qemu-devel] [PATCH for-1.6] linux-user: Return success from m68k set_thread_area syscall
Date: Mon, 29 Jul 2013 11:31:49 +0100 [thread overview]
Message-ID: <1375093909-13653-1-git-send-email-peter.maydell@linaro.org> (raw)
The m68k set_thread_area syscall implementation failed to set the
return value. Correctly set it zero, since this syscall will always
succeed.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Oops. Spotted by clang.
linux-user/syscall.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 3f6db4b..f986548 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8523,6 +8523,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
{
TaskState *ts = ((CPUArchState *)cpu_env)->opaque;
ts->tp_value = arg1;
+ ret = 0;
break;
}
#else
--
1.7.9.5
next reply other threads:[~2013-07-29 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 10:31 Peter Maydell [this message]
2013-08-02 12:35 ` [Qemu-devel] [PATCH for-1.6] linux-user: Return success from m68k set_thread_area syscall Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375093909-13653-1-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=Laurent@vivier.eu \
--cc=aliguori@us.ibm.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).