From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3mcB-0000b8-9o for qemu-devel@nongnu.org; Mon, 29 Jul 2013 08:31:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3lnR-00067B-CN for qemu-devel@nongnu.org; Mon, 29 Jul 2013 07:40:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3lnQ-00066s-Ug for qemu-devel@nongnu.org; Mon, 29 Jul 2013 07:39:25 -0400 Message-ID: <1375097942.18120.7.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Mon, 29 Jul 2013 14:39:02 +0300 In-Reply-To: <51F65186.8020004@redhat.com> References: <1375002894-26742-1-git-send-email-marcel.a@redhat.com> <51F61B76.30504@redhat.com> <1375084808.14541.12.camel@localhost.localdomain> <51F65186.8020004@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] qemu-help: improve -device command line help List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, afaerber@suse.de On Mon, 2013-07-29 at 13:27 +0200, Paolo Bonzini wrote: > Il 29/07/2013 10:00, Marcel Apfelbaum ha scritto: > > On Mon, 2013-07-29 at 09:36 +0200, Paolo Bonzini wrote: > >> Il 28/07/2013 11:14, Marcel Apfelbaum ha scritto: > >>> Categories: > >>> Assembly - hosts/hubs/... > >> > >> A lot of these seem to fit in a "bridge" category. > > I wanted to group in a category as much as possible having in > > mind the user shall "grep" by category to find devices. > > My goal is a top category with devices that are not nodes and > > are used as a way to combine other devices. > >> > >> I'm not sure why usbhost is in the assembly category though. Also, why > >> is this the default category for isa and i2c devices? > > The same argument as above. I am looking for top devices and not for > > their type > > USB host is a leaf device. As to ISA and I2C, which devices exactly are > using the default you're setting here? Are they really bridge- or > controller-type device? After moving the devices you specified from "Management" to their correct category, all the remaining devices were usb, so I renamed the category to USB (Management is empty, so removed) Regarding the ISA devices, I spread them between categories: name "isa-ide", bus ISA, categories "Storage" name "ne2k_isa", bus ISA, categories "Network" name "isa-parallel", bus ISA, categories "Input" name "isa-serial", bus ISA, categories "Input" name "isa-cirrus-vga", bus ISA, categories "Display" name "isa-vga", bus ISA, categories "Display" name "isa-applesmc", bus ISA, categories "Misc" name "isa-debugcon", bus ISA, categories "Misc" name "isa-debug-exit", bus ISA, categories "Misc" Regarding the I2C device, I moved it to the misc Category, I was misled by the name. Thanks > > >>> Management - controllers > >> > >> AHCI is storage. > > Thanks, it looked like management to me. > > Devices in management category shall control other devices. > > It looked like a fit for me. > > Yeah, it does, but then the same is true for all SCSI HBAs. > > >> applesmc is something like a microcontroller ("misc"?). > > Thanks, I'll move to misc > >> > >> Everything else in this category is USB host controllers, I think it > >> deserves a special category since USB devices are generally somewhat > >> self-explanatory (hubs too). > > I didn't want to include the "USB" keyword, because the user will be lost > > when filtering by this word. The goal is to help the user to concentrate > > on a specific "category". Maybe USB-Controller ? > > Maybe two categories (USB | Controller)? There is also difference > between storage controllers and storage devices (i.e. disks). > > I think assembly and management can be merged into a single > "controller/hub/bridge" category. You can then use multiple categories > for HBAs, for AHCI, etc. As mentioned above , the "Management" category disappear, so Assembly includes should be now controller/hub/bridge I'll release a version soon. Thanks! > > Paolo