qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Anthony Liguori" <aliguori@us.ibm.com>,
	patches@linaro.org, "Alexander Graf" <agraf@suse.de>,
	"Andreas Färber" <andreas.faerber@web.de>,
	qemu-ppc@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 0/4] Rename all 'dprintf' macros to 'DPRINTF'
Date: Mon, 29 Jul 2013 13:16:35 +0100	[thread overview]
Message-ID: <1375100199-13934-1-git-send-email-peter.maydell@linaro.org> (raw)

'dprintf' is the name of a POSIX standard function:
 http://pubs.opengroup.org/onlinepubs/9699919799/functions/dprintf.html
and so we should not steal the name to use as a debug macro.
The clang compiler in particular will emit a warning about this
redefinition:

  hw/net/spapr_llan.c:43:9: error: 'dprintf' macro redefined [-Werror]
#define dprintf(fmt...)
        ^
/usr/include/x86_64-linux-gnu/bits/stdio2.h:189:12: note: previous definition is here
#   define dprintf(fd, ...) \
           ^
1 error generated.

This patch series fixes this with the simple approach
of renaming all the users of a 'dprintf' macro to 'DPRINTF'
(which is what this macro is already called in a number of
other files in the tree). It's almost entirely a simple
search and replace; there are two cases where I folded an
overlong line that checkpatch complained about.


Peter Maydell (4):
  block/sheepdog: Rename 'dprintf' to 'DPRINTF'
  s390x: Rename 'dprintf' to 'DPRINTF'
  target-ppc/kvm.c: Rename 'dprintf' to 'DPRINTF'
  spapr: Rename 'dprintf' to 'DPRINTF'

 block/sheepdog.c           |   30 ++++++++++++-------------
 hw/net/spapr_llan.c        |   26 +++++++++++-----------
 hw/ppc/spapr_vio.c         |    8 +++----
 hw/s390x/s390-virtio-bus.c |    4 ++--
 hw/s390x/s390-virtio.c     |    4 ++--
 hw/scsi/spapr_vscsi.c      |   49 +++++++++++++++++++++--------------------
 target-ppc/kvm.c           |   52 ++++++++++++++++++++++----------------------
 target-s390x/kvm.c         |   19 ++++++++--------
 8 files changed, 97 insertions(+), 95 deletions(-)

-- 
1.7.9.5

             reply	other threads:[~2013-07-29 12:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29 12:16 Peter Maydell [this message]
2013-07-29 12:16 ` [Qemu-devel] [PATCH 1/4] block/sheepdog: Rename 'dprintf' to 'DPRINTF' Peter Maydell
2013-07-29 12:44   ` Kevin Wolf
2013-07-29 23:39     ` MORITA Kazutaka
2013-07-29 12:16 ` [Qemu-devel] [PATCH 2/4] s390x: " Peter Maydell
2013-07-29 12:16 ` [Qemu-devel] [PATCH 3/4] target-ppc/kvm.c: " Peter Maydell
2013-07-29 12:16 ` [Qemu-devel] [PATCH 4/4] spapr: " Peter Maydell
2013-07-29 16:38 ` [Qemu-devel] [PATCH 0/4] Rename all 'dprintf' macros " Richard Henderson
2013-07-29 17:34 ` Andreas Färber
2013-08-02 12:35 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375100199-13934-1-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=andreas.faerber@web.de \
    --cc=kwolf@redhat.com \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).