From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3x3e-0001Us-3m for qemu-devel@nongnu.org; Mon, 29 Jul 2013 19:41:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3x3V-00038X-Kz for qemu-devel@nongnu.org; Mon, 29 Jul 2013 19:40:54 -0400 Received: from mail-pd0-x22a.google.com ([2607:f8b0:400e:c02::22a]:58650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3x3V-00038H-DL for qemu-devel@nongnu.org; Mon, 29 Jul 2013 19:40:45 -0400 Received: by mail-pd0-f170.google.com with SMTP id x10so1510311pdj.1 for ; Mon, 29 Jul 2013 16:40:44 -0700 (PDT) From: Pawit Pornkitprasan Date: Tue, 30 Jul 2013 08:39:52 +0900 Message-Id: <1375141192-1121-1-git-send-email-p.pawit@gmail.com> Subject: [Qemu-devel] [PATCH v2] migration: don't use uninitialized variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Luiz Capitulino , Pawit Pornkitprasan , Ryousei Takano , Juan Quintela The qmp_migrate method uses the 'blk' and 'inc' parameter without checking if they're valid or not (they may be uninitialized if command is received via QMP) Signed-off-by: Pawit Pornkitprasan --- migration.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index 9fc7294..57a7998 100644 --- a/migration.c +++ b/migration.c @@ -399,8 +399,8 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk, MigrationParams params; const char *p; - params.blk = blk; - params.shared = inc; + params.blk = has_blk && blk; + params.shared = has_inc && inc; if (s->state == MIG_STATE_ACTIVE || s->state == MIG_STATE_SETUP) { error_set(errp, QERR_MIGRATION_ACTIVE); -- 1.7.3.4