From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, famz@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/7] Implement reference count for BlockDriverState
Date: Tue, 30 Jul 2013 15:52:50 +0800 [thread overview]
Message-ID: <1375170777-31457-1-git-send-email-famz@redhat.com> (raw)
BlockDriverState lifecycle management is needed by future features such as
image fleecing and blockdev-add. This series adds reference count to
BlockDriverState.
The first two patches clean up two odd BlockDriverState use cases, so all code
uses bdrv_new() to create BlockDriverState instance.
Then implemented bdrv_ref() and bdrv_unref() to operate on refcnt: Initially,
refcnt is 1, which means bdrv_unref is effectively a bdrv_delete() here. So
patch 04 has a search and replace to convert bdrv_delete to bdrv_unref, before
bdrv_ref is used anywhere. 05~08 patches calls bdrv_ref for device attach,
block-migration and nbd.
The rule is: Either bdrv_ref() or bdrv_new() must have a matching
bdrv_unref() call, and the last matching bdrv_unref deletes the bs.
v2:
05: Removed: "block: use BlockDriverState refcnt for device attach/detach"
07: Fix xen_disk blk_disconnect() as it depended on device attach refcnt.
Fam Zheng (7):
vvfat: use bdrv_new() to allocate BlockDriverState
iscsi: use bdrv_new() instead of stack structure
block: implement reference count for BlockDriverState
block: make bdrv_delete() static
migration: omit drive ref as we have bdrv_ref now
xen_disk: simplify blk_disconnect with refcnt
nbd: use BlockDriverState refcnt
block-migration.c | 4 ++--
block.c | 45 ++++++++++++++++++++++++++++++++++-----------
block/backup.c | 2 +-
block/blkverify.c | 4 ++--
block/cow.c | 2 +-
block/iscsi.c | 14 +++++++-------
block/mirror.c | 2 +-
block/qcow.c | 2 +-
block/qcow2.c | 2 +-
block/qed.c | 2 +-
block/sheepdog.c | 6 +++---
block/snapshot.c | 2 +-
block/stream.c | 2 +-
block/vmdk.c | 10 +++++-----
block/vvfat.c | 6 +++---
blockdev-nbd.c | 10 +---------
blockdev.c | 14 +++++++-------
hw/block/xen_disk.c | 13 ++++++-------
include/block/block.h | 3 ++-
include/block/block_int.h | 1 +
nbd.c | 5 +++++
qemu-img.c | 26 +++++++++++++-------------
qemu-io.c | 6 +++---
23 files changed, 102 insertions(+), 81 deletions(-)
--
1.8.3.4
next reply other threads:[~2013-07-30 8:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 7:52 Fam Zheng [this message]
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 1/7] vvfat: use bdrv_new() to allocate BlockDriverState Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 2/7] iscsi: use bdrv_new() instead of stack structure Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState Fam Zheng
2013-07-30 12:16 ` Andreas Färber
2013-07-30 14:50 ` Stefan Hajnoczi
2013-07-30 14:51 ` Jeff Cody
2013-07-30 14:58 ` Stefan Hajnoczi
2013-07-31 9:51 ` Fam Zheng
2013-08-01 9:30 ` Stefan Hajnoczi
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 4/7] block: make bdrv_delete() static Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 5/7] migration: omit drive ref as we have bdrv_ref now Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 6/7] xen_disk: simplify blk_disconnect with refcnt Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 7/7] nbd: use BlockDriverState refcnt Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375170777-31457-1-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).