From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V44sD-0000Un-A0 for qemu-devel@nongnu.org; Tue, 30 Jul 2013 04:01:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V44kG-0004e4-T2 for qemu-devel@nongnu.org; Tue, 30 Jul 2013 03:54:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V44kG-0004dr-Hq for qemu-devel@nongnu.org; Tue, 30 Jul 2013 03:53:24 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6U7rNGB006908 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 30 Jul 2013 03:53:23 -0400 From: Fam Zheng Date: Tue, 30 Jul 2013 15:52:50 +0800 Message-Id: <1375170777-31457-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v2 0/7] Implement reference count for BlockDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, famz@redhat.com, stefanha@redhat.com BlockDriverState lifecycle management is needed by future features such as image fleecing and blockdev-add. This series adds reference count to BlockDriverState. The first two patches clean up two odd BlockDriverState use cases, so all code uses bdrv_new() to create BlockDriverState instance. Then implemented bdrv_ref() and bdrv_unref() to operate on refcnt: Initially, refcnt is 1, which means bdrv_unref is effectively a bdrv_delete() here. So patch 04 has a search and replace to convert bdrv_delete to bdrv_unref, before bdrv_ref is used anywhere. 05~08 patches calls bdrv_ref for device attach, block-migration and nbd. The rule is: Either bdrv_ref() or bdrv_new() must have a matching bdrv_unref() call, and the last matching bdrv_unref deletes the bs. v2: 05: Removed: "block: use BlockDriverState refcnt for device attach/detach" 07: Fix xen_disk blk_disconnect() as it depended on device attach refcnt. Fam Zheng (7): vvfat: use bdrv_new() to allocate BlockDriverState iscsi: use bdrv_new() instead of stack structure block: implement reference count for BlockDriverState block: make bdrv_delete() static migration: omit drive ref as we have bdrv_ref now xen_disk: simplify blk_disconnect with refcnt nbd: use BlockDriverState refcnt block-migration.c | 4 ++-- block.c | 45 ++++++++++++++++++++++++++++++++++----------- block/backup.c | 2 +- block/blkverify.c | 4 ++-- block/cow.c | 2 +- block/iscsi.c | 14 +++++++------- block/mirror.c | 2 +- block/qcow.c | 2 +- block/qcow2.c | 2 +- block/qed.c | 2 +- block/sheepdog.c | 6 +++--- block/snapshot.c | 2 +- block/stream.c | 2 +- block/vmdk.c | 10 +++++----- block/vvfat.c | 6 +++--- blockdev-nbd.c | 10 +--------- blockdev.c | 14 +++++++------- hw/block/xen_disk.c | 13 ++++++------- include/block/block.h | 3 ++- include/block/block_int.h | 1 + nbd.c | 5 +++++ qemu-img.c | 26 +++++++++++++------------- qemu-io.c | 6 +++--- 23 files changed, 102 insertions(+), 81 deletions(-) -- 1.8.3.4