From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, famz@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v2 1/7] vvfat: use bdrv_new() to allocate BlockDriverState
Date: Tue, 30 Jul 2013 15:52:51 +0800 [thread overview]
Message-ID: <1375170777-31457-2-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1375170777-31457-1-git-send-email-famz@redhat.com>
we need bdrv_new() to properly initialize BDS, don't allocate memory
manually.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/vvfat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index cd3b8ed..a827d91 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2943,7 +2943,7 @@ static int enable_write_target(BDRVVVFATState *s)
unlink(s->qcow_filename);
#endif
- s->bs->backing_hd = calloc(sizeof(BlockDriverState), 1);
+ s->bs->backing_hd = bdrv_new("");
s->bs->backing_hd->drv = &vvfat_write_target;
s->bs->backing_hd->opaque = g_malloc(sizeof(void*));
*(void**)s->bs->backing_hd->opaque = s;
--
1.8.3.4
next prev parent reply other threads:[~2013-07-30 8:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 7:52 [Qemu-devel] [PATCH v2 0/7] Implement reference count for BlockDriverState Fam Zheng
2013-07-30 7:52 ` Fam Zheng [this message]
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 2/7] iscsi: use bdrv_new() instead of stack structure Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState Fam Zheng
2013-07-30 12:16 ` Andreas Färber
2013-07-30 14:50 ` Stefan Hajnoczi
2013-07-30 14:51 ` Jeff Cody
2013-07-30 14:58 ` Stefan Hajnoczi
2013-07-31 9:51 ` Fam Zheng
2013-08-01 9:30 ` Stefan Hajnoczi
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 4/7] block: make bdrv_delete() static Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 5/7] migration: omit drive ref as we have bdrv_ref now Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 6/7] xen_disk: simplify blk_disconnect with refcnt Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 7/7] nbd: use BlockDriverState refcnt Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375170777-31457-2-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).