From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4SbX-00089I-UG for qemu-devel@nongnu.org; Wed, 31 Jul 2013 05:22:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4SbR-0001jv-6g for qemu-devel@nongnu.org; Wed, 31 Jul 2013 05:21:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4SbQ-0001jk-Vz for qemu-devel@nongnu.org; Wed, 31 Jul 2013 05:21:53 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6V9LqJX003491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 31 Jul 2013 05:21:52 -0400 From: Gerd Hoffmann Date: Wed, 31 Jul 2013 11:21:51 +0200 Message-Id: <1375262511-28604-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH] usb-redir: fix use-after-free List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Reinitialize dev->cs to NULL after deleting it, to make sure it isn't used afterwards. Reported-by: Martin Cerveny Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 8b8c010..e3b9f32 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -1334,6 +1334,7 @@ static void usbredir_handle_destroy(USBDevice *udev) USBRedirDevice *dev = DO_UPCAST(USBRedirDevice, dev, udev); qemu_chr_delete(dev->cs); + dev->cs = NULL; /* Note must be done after qemu_chr_close, as that causes a close event */ qemu_bh_delete(dev->chardev_close_bh); -- 1.7.9.7