From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4dp8-0007tT-L6 for qemu-devel@nongnu.org; Wed, 31 Jul 2013 17:20:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4dot-0004gq-Up for qemu-devel@nongnu.org; Wed, 31 Jul 2013 17:20:46 -0400 Received: from mail.ukfsn.org ([5.9.116.23]:39003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4dot-0004ga-Fj for qemu-devel@nongnu.org; Wed, 31 Jul 2013 17:20:31 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.ukfsn.org (Postfix) with SMTP id ED935DC1959 for ; Wed, 31 Jul 2013 22:20:29 +0100 (BST) From: "Richard W.M. Jones" Date: Wed, 31 Jul 2013 22:20:26 +0100 Message-Id: <1375305626-26972-1-git-send-email-rjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v3] block/iscsi.c: Fix printf format error. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, sw@weilnetz.de, afaerber@suse.de From: "Richard W.M. Jones" The error on armv7hl was: block/iscsi.c: In function =E2=80=98is_request_lun_aligned=E2=80=99: block/iscsi.c:251:26: error: format =E2=80=98%ld=E2=80=99 expects argumen= t of type =E2=80=98long int=E2=80=99, but argument 3 has type =E2=80=98in= t64_t=E2=80=99 [-Werror=3Dformat=3D] iscsilun->block_size, sector_num, nb_sectors); ^ This also splits the long line to comply with qemu coding guidelines. Signed-off-by: Richard W.M. Jones --- block/iscsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 5f28c6a..e7c1c2b 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -247,7 +247,9 @@ static bool is_request_lun_aligned(int64_t sector_num= , int nb_sectors, { if ((sector_num * BDRV_SECTOR_SIZE) % iscsilun->block_size || (nb_sectors * BDRV_SECTOR_SIZE) % iscsilun->block_size) { - error_report("iSCSI misaligned request: iscsilun->block_size= %u, sector_num %ld, nb_sectors %d", + error_report("iSCSI misaligned request: " + "iscsilun->block_size %u, sector_num %" PRIi64 + ", nb_sectors %d", iscsilun->block_size, sector_num, nb_sectors); return 0; } --=20 1.8.3.1