From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Alexander Graf" <agraf@suse.de>,
"open list:sPAPR" <qemu-ppc@nongnu.org>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"Prerna Saxena" <prerna@linux.vnet.ibm.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH for-next] spapr: Avoid "HOST@0" CPU node name in SLOF device tree for -cpu host
Date: Thu, 1 Aug 2013 03:02:21 +0200 [thread overview]
Message-ID: <1375318941-17624-1-git-send-email-afaerber@suse.de> (raw)
By default on KVM or when user asks for it via -cpu host, cpu_model will
be "host" and sPAPR merely upper-cases it for the SLOF device tree.
Change it so that we get the underlying CPU type, e.g., "POWER7_V2.3@0".
Reported-by: Prerna Saxena <prerna@linux.vnet.ibm.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
This avoids a PVR based lookup in common code.
Tested with local patches for POWER5+_v2.1 support and modified SLOF.
hw/ppc/spapr.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 16bfab9..95579b9 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1072,7 +1072,7 @@ static void ppc_spapr_init(QEMUMachineInitArgs *args)
const char *kernel_cmdline = args->kernel_cmdline;
const char *initrd_filename = args->initrd_filename;
const char *boot_device = args->boot_device;
- PowerPCCPU *cpu;
+ PowerPCCPU *cpu = NULL;
CPUPPCState *env;
PCIHostState *phb;
int i;
@@ -1307,6 +1307,15 @@ static void ppc_spapr_init(QEMUMachineInitArgs *args)
register_savevm_live(NULL, "spapr/htab", -1, 1,
&savevm_htab_handlers, spapr);
+ if (kvm_enabled() && strcmp(cpu_model, "host") == 0) {
+ ObjectClass *cpu_class = object_get_class(OBJECT(cpu));
+ ObjectClass *parent_cpu_class = object_class_get_parent(cpu_class);
+ const char *parent_name = object_class_get_name(parent_cpu_class);
+
+ cpu_model = g_strndup(parent_name,
+ strlen(parent_name) - strlen("-" TYPE_POWERPC_CPU));
+ }
+
/* Prepare the device tree */
spapr->fdt_skel = spapr_create_fdt_skel(cpu_model,
initrd_base, initrd_size,
--
1.8.1.4
next reply other threads:[~2013-08-01 1:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 1:02 Andreas Färber [this message]
2013-08-08 5:15 ` [Qemu-devel] [PATCH for-next] spapr: Avoid "HOST@0" CPU node name in SLOF device tree for -cpu host Prerna Saxena
2013-08-09 11:34 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375318941-17624-1-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=anthony@codemonkey.ws \
--cc=prerna@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).