From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH for-next v2 13/22] virtio-net: Convert to QOM realize
Date: Thu, 1 Aug 2013 04:17:34 +0200 [thread overview]
Message-ID: <1375323463-32747-14-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1375323463-32747-1-git-send-email-afaerber@suse.de>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
hw/net/virtio-net.c | 18 ++++++++++--------
include/hw/virtio/virtio-net.h | 2 ++
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 05ad605..16c230f 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1484,10 +1484,12 @@ void virtio_net_set_netclient_name(VirtIONet *n, const char *name,
n->netclient_type = g_strdup(type);
}
-static int virtio_net_device_init(VirtIODevice *vdev)
+static void virtio_net_device_realize(DeviceState *dev, Error **errp)
{
- DeviceState *dev = DEVICE(vdev);
+ VirtIODevice *vdev = VIRTIO_DEVICE(dev);
VirtIONet *n = VIRTIO_NET(dev);
+ ObjectClass *parent_oc = VIRTIO_NET_GET_PARENT_CLASS(dev);
+ DeviceClass *parent_dc = DEVICE_CLASS(parent_oc);
NetClientState *nc;
int i;
@@ -1563,10 +1565,11 @@ static int virtio_net_device_init(VirtIODevice *vdev)
virtio_net_save, virtio_net_load, n);
add_boot_device_path(n->nic_conf.bootindex, dev, "/ethernet-phy@0");
- return 0;
+
+ parent_dc->realize(dev, errp);
}
-static int virtio_net_device_exit(DeviceState *dev)
+static void virtio_net_device_unrealize(DeviceState *dev, Error **errp)
{
VirtIODevice *vdev = VIRTIO_DEVICE(dev);
VirtIONet *n = VIRTIO_NET(dev);
@@ -1606,8 +1609,6 @@ static int virtio_net_device_exit(DeviceState *dev)
g_free(n->vqs);
qemu_del_nic(n->nic);
virtio_cleanup(vdev);
-
- return 0;
}
static void virtio_net_instance_init(Object *obj)
@@ -1634,10 +1635,11 @@ static void virtio_net_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
- dc->exit = virtio_net_device_exit;
+
+ dc->realize = virtio_net_device_realize;
+ dc->unrealize = virtio_net_device_unrealize;
dc->props = virtio_net_properties;
set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
- vdc->init = virtio_net_device_init;
vdc->get_config = virtio_net_get_config;
vdc->set_config = virtio_net_set_config;
vdc->get_features = virtio_net_get_features;
diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h
index df60f16..f1efed2 100644
--- a/include/hw/virtio/virtio-net.h
+++ b/include/hw/virtio/virtio-net.h
@@ -20,6 +20,8 @@
#define TYPE_VIRTIO_NET "virtio-net-device"
#define VIRTIO_NET(obj) \
OBJECT_CHECK(VirtIONet, (obj), TYPE_VIRTIO_NET)
+#define VIRTIO_NET_GET_PARENT_CLASS(obj) \
+ OBJECT_GET_PARENT_CLASS(obj, TYPE_VIRTIO_NET)
#define ETH_ALEN 6
--
1.8.1.4
next prev parent reply other threads:[~2013-08-01 2:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 2:17 [Qemu-devel] [PATCH for-next v2 00/22] QOM realize for virtio Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro Andreas Färber
2013-08-06 5:54 ` Alexey Kardashevskiy
2013-08-06 8:33 ` Andreas Färber
2013-08-07 3:36 ` Alexey Kardashevskiy
2013-08-07 4:20 ` Peter Crosthwaite
2013-08-07 5:38 ` Alexey Kardashevskiy
2013-08-07 5:45 ` Andreas Färber
2013-08-07 5:53 ` Alexey Kardashevskiy
2013-08-07 6:10 ` Peter Crosthwaite
2013-08-07 6:38 ` Alexey Kardashevskiy
2013-08-07 6:28 ` Andreas Färber
2013-08-07 5:58 ` Andreas Färber
2013-08-07 1:50 ` Peter Crosthwaite
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 02/22] virtio-console: Use exitfn for virtserialport, too Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 03/22] virtio-9p-device: Avoid freeing uninitialized memory Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 04/22] virtio-blk-dataplane: Improve error reporting Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 05/22] virtio: Allow NULL VirtioDeviceClass::init hook Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 06/22] virtio-9p: QOM realize preparations Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 07/22] virtio-9p: Convert to QOM realize Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 08/22] virtio-blk: QOM realize preparations Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 09/22] virtio-blk: Convert to QOM realize Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 10/22] virtio-serial: QOM realize preparations Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 11/22] virtio-serial: Convert to QOM realize Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 12/22] virtio-net: QOM realize preparations Andreas Färber
2013-08-01 2:17 ` Andreas Färber [this message]
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 14/22] virtio-balloon: " Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 15/22] virtio-balloon: Convert to QOM realize Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 16/22] virtio-rng: QOM realize preparations Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 17/22] virtio-rng: Convert to QOM realize Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 18/22] virtio-scsi: QOM realize preparations Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 19/22] virtio-scsi: Convert to QOM realize Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 20/22] virtio: Convert VirtioDevice " Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH for-next v2 21/22] virtio: Unrealize parent Andreas Färber
2013-08-01 2:17 ` [Qemu-devel] [PATCH RFC for-next v2 22/22] virtio-scsi: Convert virtio_scsi_common_[un]realize to QOM realize Andreas Färber
2013-08-01 2:22 ` [Qemu-devel] [PATCH for-next v2 00/22] QOM realize for virtio Andreas Färber
2013-08-14 16:28 ` Anthony Liguori
2013-08-14 16:49 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375323463-32747-14-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).