qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH for-next v2 05/22] virtio: Allow NULL VirtioDeviceClass::init hook
Date: Thu,  1 Aug 2013 04:17:26 +0200	[thread overview]
Message-ID: <1375323463-32747-6-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1375323463-32747-1-git-send-email-afaerber@suse.de>

This is a temporary measure to allow mixing VirtioDeviceClass::init with
DeviceClass::realize.

Clean up variable naming in preparation for QOM realize.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 hw/virtio/virtio.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 09f62c6..c00c224 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -1139,13 +1139,15 @@ void virtio_device_set_child_bus_name(VirtIODevice *vdev, char *bus_name)
     }
 }
 
-static int virtio_device_init(DeviceState *qdev)
+static int virtio_device_init(DeviceState *dev)
 {
-    VirtIODevice *vdev = VIRTIO_DEVICE(qdev);
-    VirtioDeviceClass *k = VIRTIO_DEVICE_GET_CLASS(qdev);
-    assert(k->init != NULL);
-    if (k->init(vdev) < 0) {
-        return -1;
+    VirtIODevice *vdev = VIRTIO_DEVICE(dev);
+    VirtioDeviceClass *vdc = VIRTIO_DEVICE_GET_CLASS(dev);
+
+    if (vdc->init != NULL) {
+        if (vdc->init(vdev) < 0) {
+            return -1;
+        }
     }
     virtio_bus_plug_device(vdev);
     return 0;
-- 
1.8.1.4

  parent reply	other threads:[~2013-08-01  2:18 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01  2:17 [Qemu-devel] [PATCH for-next v2 00/22] QOM realize for virtio Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro Andreas Färber
2013-08-06  5:54   ` Alexey Kardashevskiy
2013-08-06  8:33     ` Andreas Färber
2013-08-07  3:36       ` Alexey Kardashevskiy
2013-08-07  4:20         ` Peter Crosthwaite
2013-08-07  5:38           ` Alexey Kardashevskiy
2013-08-07  5:45             ` Andreas Färber
2013-08-07  5:53               ` Alexey Kardashevskiy
2013-08-07  6:10                 ` Peter Crosthwaite
2013-08-07  6:38                   ` Alexey Kardashevskiy
2013-08-07  6:28                 ` Andreas Färber
2013-08-07  5:58         ` Andreas Färber
2013-08-07  1:50   ` Peter Crosthwaite
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 02/22] virtio-console: Use exitfn for virtserialport, too Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 03/22] virtio-9p-device: Avoid freeing uninitialized memory Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 04/22] virtio-blk-dataplane: Improve error reporting Andreas Färber
2013-08-01  2:17 ` Andreas Färber [this message]
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 06/22] virtio-9p: QOM realize preparations Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 07/22] virtio-9p: Convert to QOM realize Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 08/22] virtio-blk: QOM realize preparations Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 09/22] virtio-blk: Convert to QOM realize Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 10/22] virtio-serial: QOM realize preparations Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 11/22] virtio-serial: Convert to QOM realize Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 12/22] virtio-net: QOM realize preparations Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 13/22] virtio-net: Convert to QOM realize Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 14/22] virtio-balloon: QOM realize preparations Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 15/22] virtio-balloon: Convert to QOM realize Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 16/22] virtio-rng: QOM realize preparations Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 17/22] virtio-rng: Convert to QOM realize Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 18/22] virtio-scsi: QOM realize preparations Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 19/22] virtio-scsi: Convert to QOM realize Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 20/22] virtio: Convert VirtioDevice " Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH for-next v2 21/22] virtio: Unrealize parent Andreas Färber
2013-08-01  2:17 ` [Qemu-devel] [PATCH RFC for-next v2 22/22] virtio-scsi: Convert virtio_scsi_common_[un]realize to QOM realize Andreas Färber
2013-08-01  2:22 ` [Qemu-devel] [PATCH for-next v2 00/22] QOM realize for virtio Andreas Färber
2013-08-14 16:28 ` Anthony Liguori
2013-08-14 16:49   ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375323463-32747-6-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).