qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <famz@redhat.com>
Subject: [Qemu-devel] [PATCH EMBARGOED 2/7] vmdk: use unsigned values for on disk header fields
Date: Fri,  2 Aug 2013 15:48:36 +0800	[thread overview]
Message-ID: <1375429721-15276-3-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1375429721-15276-1-git-send-email-famz@redhat.com>

The size and offset fields are all non-negative values, use uint64_t for
them to avoid getting negative in memory value by int overflow.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block/vmdk.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/block/vmdk.c b/block/vmdk.c
index 8ff43b9..3c6fa47 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -67,14 +67,14 @@ typedef struct {
 typedef struct {
     uint32_t version;
     uint32_t flags;
-    int64_t capacity;
-    int64_t granularity;
-    int64_t desc_offset;
-    int64_t desc_size;
-    int32_t num_gtes_per_gte;
-    int64_t rgd_offset;
-    int64_t gd_offset;
-    int64_t grain_offset;
+    uint64_t capacity;
+    uint64_t granularity;
+    uint64_t desc_offset;
+    uint64_t desc_size;
+    uint32_t num_gtes_per_gte;
+    uint64_t rgd_offset;
+    uint64_t gd_offset;
+    uint64_t grain_offset;
     char filler[1];
     char check_bytes[4];
     uint16_t compressAlgorithm;
-- 
1.8.3.4

  parent reply	other threads:[~2013-08-02  8:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1375429721-15276-1-git-send-email-famz@redhat.com>
2013-08-02  7:48 ` [Qemu-devel] [PATCH EMBARGOED 1/7] vmdk: Make VMDK3Header QEMU_PACKED Fam Zheng
2013-08-02  7:48 ` Fam Zheng [this message]
2013-08-02  7:48 ` [Qemu-devel] [PATCH EMBARGOED 3/7] qemu-iotests: add empty test case for vmdk Fam Zheng
2013-08-02  7:48 ` [Qemu-devel] [PATCH EMBARGOED 4/7] vmdk: check granularity field in opening Fam Zheng
2013-08-02  7:48 ` [Qemu-devel] [PATCH EMBARGOED 5/7] vmdk: check cluster size in vmdk_open Fam Zheng
2013-08-02  7:48 ` [Qemu-devel] [PATCH EMBARGOED 6/7] vmdk: check l2 table size when opening Fam Zheng
2013-08-02  7:48 ` [Qemu-devel] [PATCH EMBARGOED 7/7] vmdk: check l1 size before opening image Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375429721-15276-3-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).