From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5AOF-0002r6-OS for qemu-devel@nongnu.org; Fri, 02 Aug 2013 04:07:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5A6w-0005V8-3J for qemu-devel@nongnu.org; Fri, 02 Aug 2013 03:49:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5A6v-0005Uz-NG for qemu-devel@nongnu.org; Fri, 02 Aug 2013 03:49:17 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r727nHt1025301 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 2 Aug 2013 03:49:17 -0400 From: Fam Zheng Date: Fri, 2 Aug 2013 15:48:36 +0800 Message-Id: <1375429721-15276-3-git-send-email-famz@redhat.com> In-Reply-To: <1375429721-15276-1-git-send-email-famz@redhat.com> References: <1375429721-15276-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH EMBARGOED 2/7] vmdk: use unsigned values for on disk header fields List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Fam Zheng The size and offset fields are all non-negative values, use uint64_t for them to avoid getting negative in memory value by int overflow. Signed-off-by: Fam Zheng --- block/vmdk.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 8ff43b9..3c6fa47 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -67,14 +67,14 @@ typedef struct { typedef struct { uint32_t version; uint32_t flags; - int64_t capacity; - int64_t granularity; - int64_t desc_offset; - int64_t desc_size; - int32_t num_gtes_per_gte; - int64_t rgd_offset; - int64_t gd_offset; - int64_t grain_offset; + uint64_t capacity; + uint64_t granularity; + uint64_t desc_offset; + uint64_t desc_size; + uint32_t num_gtes_per_gte; + uint64_t rgd_offset; + uint64_t gd_offset; + uint64_t grain_offset; char filler[1]; char check_bytes[4]; uint16_t compressAlgorithm; -- 1.8.3.4