From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5BPh-00055U-RD for qemu-devel@nongnu.org; Fri, 02 Aug 2013 05:12:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5BPZ-0000Md-2O for qemu-devel@nongnu.org; Fri, 02 Aug 2013 05:12:45 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:53368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5BPY-0000M3-FR for qemu-devel@nongnu.org; Fri, 02 Aug 2013 05:12:36 -0400 Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 2 Aug 2013 14:27:04 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 7E1AF1258051 for ; Fri, 2 Aug 2013 14:31:59 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7292Ixq31785038 for ; Fri, 2 Aug 2013 14:32:19 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r7292LUo014702 for ; Fri, 2 Aug 2013 19:02:22 +1000 From: Xu Wang Date: Fri, 2 Aug 2013 05:02:11 -0400 Message-Id: <1375434137-4452-1-git-send-email-gesaint@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V5 0/6] Refine and export backing file loop check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, wdongxu@linux.vnet.ibm.com, Xu Wang , xiawenc@linux.vnet.ibm.com From: Xu Wang If there is loop exists in the backing file chain, many problems could be caused by it, such as no response and segment fault during system boot. Hence stopping backing file loop appear is very necessary. These patches refine and export loop checking function from collect_image_ info_list() to block.c and build a independent function named bdrv_ backing_file_loop_check(). Backing file loop checking is added before image created, before change backing file and before system boot. Updates from V4: 1. Add backing file loop check in bdrv_new_open(). 2. Adjust open file logic of collect_image_info_list() (bdrv_new_open() is called only once when opening the whole chain). 3. Remove redundant brackets in lnk file check logic. 4. Add error output in bdrv_img_create(). 5. Remove MAX_PATH_LEN to use PATH_MAX instead. Updates from V3: 1. Comments fix for function bdrv_backing_file_loop_check(). 2. Add ret check for fseek()/fread() in get_lnk_target_file(). 3. Add limit of shortcuts filename length reading during comparing. 4. Add error_report() in driv_init(). 5. Remove redundant loop check in qcow2/qed_change_backing_file(). Updates from V2: 1. Removed parameter @chain from bdrv_backing_file_loop_check() 2. Comments and format fix, all patches were checked by checkpatch.pl 3. Fixed *bs leak. 4. Improved logic of .lnk file recognization. 5. Add filename lenth limit check in while() 6. Changed get_win_inode() to get_inode() and move all inode get method into it to make logic more simpler. 7. Added value of @fmt as suggested. 8. Added backing file loop check in qcow2.c/qed.c Xu Wang (6): block/qemu-img: Refine and export infinite loop checking in collect_image_info_list() qemu-img: Add infinite loop checking in bdrv_new_open() block: Add WIN32 platform support for backing_file_loop_check() block: Check infinite loop in bdrv_img_create() block: Add backing file loop check in change_backing_file() block: Add infinite loop check in drive_init() block.c | 253 +++++++++++++++++++++++++++++++++++++++++++++++++- blockdev.c | 7 ++ include/block/block.h | 4 + qemu-img.c | 51 +++++----- 4 files changed, 284 insertions(+), 31 deletions(-) -- 1.8.1.4