From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5BPx-0005Uz-Cc for qemu-devel@nongnu.org; Fri, 02 Aug 2013 05:13:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5BPo-0000R8-9H for qemu-devel@nongnu.org; Fri, 02 Aug 2013 05:13:01 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:42970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5BPn-0000QS-HX for qemu-devel@nongnu.org; Fri, 02 Aug 2013 05:12:52 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 2 Aug 2013 14:25:30 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 87B423940057 for ; Fri, 2 Aug 2013 14:32:28 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7293Zie7471206 for ; Fri, 2 Aug 2013 14:33:35 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r7292TXD015506 for ; Fri, 2 Aug 2013 19:02:29 +1000 From: Xu Wang Date: Fri, 2 Aug 2013 05:02:17 -0400 Message-Id: <1375434137-4452-7-git-send-email-gesaint@linux.vnet.ibm.com> In-Reply-To: <1375434137-4452-1-git-send-email-gesaint@linux.vnet.ibm.com> References: <1375434137-4452-1-git-send-email-gesaint@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V5 6/6] block: Add infinite loop check in drive_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, wdongxu@linux.vnet.ibm.com, Xu Wang , xiawenc@linux.vnet.ibm.com From: Xu Wang Backing file should be checked if there is a loop in it during image boot. Becase if there is loop qemu would no response for a long time and segment fault occured. So this patch would check backing file chain if there is loop in it before open image. Signed-off-by: Xu Wang --- blockdev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/blockdev.c b/blockdev.c index b3a57e0..590193f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -695,6 +695,13 @@ DriveInfo *drive_init(QemuOpts *all_opts, BlockInterfaceType block_default_type) error_report("warning: disabling copy_on_read on readonly drive"); } + /* Add backing file loop check */ + if (bdrv_backing_file_loop_check(file, drv ? drv->format_name : NULL, + NULL, NULL)) { + error_report("drive_init: backing file loop check failed!"); + goto err; + } + ret = bdrv_open(dinfo->bdrv, file, bs_opts, bdrv_flags, drv); bs_opts = NULL; -- 1.8.1.4