From: Fabien Chouteau <chouteau@adacore.com>
To: qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 1/2] Improve Monitor disas with symbol lookup
Date: Fri, 2 Aug 2013 14:48:27 +0200 [thread overview]
Message-ID: <1375447708-14545-1-git-send-email-chouteau@adacore.com> (raw)
Part of M731-018.
Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
---
disas.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/disas.c b/disas.c
index 71007fb..3ffb3ae 100644
--- a/disas.c
+++ b/disas.c
@@ -480,11 +480,19 @@ void monitor_disas(Monitor *mon, CPUArchState *env,
#endif
for(i = 0; i < nb_insn; i++) {
- monitor_printf(mon, "0x" TARGET_FMT_lx ": ", pc);
+ const char *sym = lookup_symbol(pc);
+
+ monitor_printf(mon, "0x" TARGET_FMT_lx " ", pc);
+ if (sym[0] != '\0') {
+ monitor_printf(mon, "<%s>: ", sym);
+ } else {
+ monitor_printf(mon, ": ");
+ }
count = print_insn(pc, &s.info);
- monitor_printf(mon, "\n");
- if (count < 0)
- break;
+ monitor_printf(mon, "\n");
+ if (count < 0) {
+ break;
+ }
pc += count;
}
}
--
1.7.9.5
next reply other threads:[~2013-08-02 21:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 12:48 Fabien Chouteau [this message]
2013-08-02 12:48 ` [Qemu-devel] [PATCH 2/2] Add ARM registers definitions in Monitor commands Fabien Chouteau
2013-08-19 8:26 ` Fabien Chouteau
2013-08-19 8:31 ` Peter Maydell
2013-08-19 14:24 ` Andreas Färber
2013-08-19 8:27 ` [Qemu-devel] [PATCH 1/2] Improve Monitor disas with symbol lookup Fabien Chouteau
2013-08-19 8:33 ` Peter Maydell
2013-08-19 14:08 ` Fabien Chouteau
2013-08-19 14:14 ` Andreas Färber
2013-08-19 16:05 ` Fabien Chouteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375447708-14545-1-git-send-email-chouteau@adacore.com \
--to=chouteau@adacore.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).