From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42406)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1V6GtS-0001y6-GW
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 05:16:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1V6GtM-0003JG-EL
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 05:15:58 -0400
Message-ID: <1375694125.12557.35.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Mon, 05 Aug 2013 19:15:25 +1000
In-Reply-To: <51FF6155.2060505@suse.de>
References: <1375412374-24701-1-git-send-email-aik@ozlabs.ru>
	<51FBDAF6.10302@suse.de> <20130805054341.GE19254@iris.ozlabs.ibm.com>
	<51FF6155.2060505@suse.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] target-ppc: Add POWER7+ CPU model
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stuart Yoder <stuart.yoder@freescale.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, qemu-ppc@nongnu.org, Scott Wood <scottwood@freescale.com>, Paul Mackerras <paulus@samba.org>

On Mon, 2013-08-05 at 10:24 +0200, Andreas F=C3=A4rber wrote:
> Ben has pointed out that POWER5++ PVR-wise was a POWER5+ v3.0+ or so
> and, according to you, POWER5++ is not just a revision with
> hardware-only changes and a new marketing name. So no, it's not always
> just the upper 16 bits.

Also 4xx uses a different bit split etc... that's why qemu should do
like the kernel and use a mask/value pair to do the matching.

Cheers,
Ben.