From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Andreas Färber" <afaerber@suse.de>,
"Paul Brook" <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH for-1.6? v2 10/21] armv7m: Don't enforce use of kernel for qtest
Date: Mon, 5 Aug 2013 15:27:16 +0200 [thread overview]
Message-ID: <1375709247-10002-11-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1375709247-10002-1-git-send-email-afaerber@suse.de>
Adopt error_report().
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
hw/arm/armv7m.c | 25 ++++++++++++++-----------
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c
index 82d36fb..ddbaf8c 100644
--- a/hw/arm/armv7m.c
+++ b/hw/arm/armv7m.c
@@ -11,6 +11,8 @@
#include "hw/arm/arm.h"
#include "hw/loader.h"
#include "elf.h"
+#include "sysemu/qtest.h"
+#include "qemu/error-report.h"
/* Bitbanded IO. Each word corresponds to a single bit. */
@@ -233,21 +235,22 @@ qemu_irq *armv7m_init(MemoryRegion *address_space_mem,
big_endian = 0;
#endif
- if (!kernel_filename) {
+ if (!kernel_filename && !qtest_enabled()) {
fprintf(stderr, "Guest image must be specified (using -kernel)\n");
exit(1);
}
- image_size = load_elf(kernel_filename, NULL, NULL, &entry, &lowaddr,
- NULL, big_endian, ELF_MACHINE, 1);
- if (image_size < 0) {
- image_size = load_image_targphys(kernel_filename, 0, flash_size);
- lowaddr = 0;
- }
- if (image_size < 0) {
- fprintf(stderr, "qemu: could not load kernel '%s'\n",
- kernel_filename);
- exit(1);
+ if (kernel_filename) {
+ image_size = load_elf(kernel_filename, NULL, NULL, &entry, &lowaddr,
+ NULL, big_endian, ELF_MACHINE, 1);
+ if (image_size < 0) {
+ image_size = load_image_targphys(kernel_filename, 0, flash_size);
+ lowaddr = 0;
+ }
+ if (image_size < 0) {
+ error_report("Could not load kernel '%s'", kernel_filename);
+ exit(1);
+ }
}
/* Hack to map an additional page of ram at the top of the address
--
1.8.1.4
next prev parent reply other threads:[~2013-08-05 13:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 13:27 [Qemu-devel] [PATCH for-1.6? v2 00/21] qtest: Test all targets Andreas Färber
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 01/21] mips_mipssim: Silence BIOS loading warning for qtest Andreas Färber
2013-08-07 10:12 ` Aurelien Jarno
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 02/21] arm/boot: Turn arm_load_kernel() into no-op for qtest without -kernel Andreas Färber
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 03/21] puv3: Turn puv3_load_kernel() into a " Andreas Färber
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 04/21] mainstone: Don't enforce use of -pflash for qtest Andreas Färber
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 05/21] gumstix: " Andreas Färber
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 06/21] z2: " Andreas Färber
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 07/21] palm: Don't enforce loading ROM or kernel " Andreas Färber
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 08/21] omap_sx1: Don't enforce use of kernel or flash " Andreas Färber
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 09/21] exynos4_boards: Silence lack of -smp 2 warning " Andreas Färber
2013-08-05 13:27 ` Andreas Färber [this message]
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 11/21] axis_dev88: Don't enforce use of kernel " Andreas Färber
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 12/21] mcf5208: " Andreas Färber
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 13/21] an5206: " Andreas Färber
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 14/21] milkymist: Suppress -kernel/-bios/-drive error " Andreas Färber
2013-08-07 5:34 ` Michael Walle
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 15/21] ppc405_boards: Disable debug output Andreas Färber
2013-08-14 17:54 ` Alexander Graf
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 16/21] ppc405_uc: " Andreas Färber
2013-08-14 17:55 ` Alexander Graf
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 17/21] ppc405_boards: Don't enforce presence of firmware for qtest Andreas Färber
2013-08-14 17:55 ` Alexander Graf
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 18/21] shix: Drop debug output Andreas Färber
2013-08-07 10:13 ` Aurelien Jarno
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 19/21] shix: Don't require firmware presence for qtest Andreas Färber
2013-08-06 8:05 ` Stefan Hajnoczi
2013-08-07 10:13 ` Aurelien Jarno
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 20/21] leon3: Don't enforce use of -bios with qtest Andreas Färber
2013-08-05 13:27 ` [Qemu-devel] [PATCH for-1.6? v2 21/21] qtest: Prepare QOM machine tests Andreas Färber
2013-08-25 17:22 ` Alexander Graf
2013-08-25 17:34 ` Andreas Färber
2013-08-25 17:33 ` Peter Maydell
2013-08-25 17:42 ` Andreas Färber
2013-08-26 13:19 ` Luiz Capitulino
2013-08-06 8:39 ` [Qemu-devel] [PATCH for-1.6? v2 00/21] qtest: Test all targets Markus Armbruster
2013-08-06 9:04 ` Andreas Färber
2013-08-06 9:45 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375709247-10002-11-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).