From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6WH1-0004rK-1d for qemu-devel@nongnu.org; Mon, 05 Aug 2013 21:41:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6WGv-00070l-2p for qemu-devel@nongnu.org; Mon, 05 Aug 2013 21:41:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6WGu-00070d-RN for qemu-devel@nongnu.org; Mon, 05 Aug 2013 21:41:13 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r761fCxw017381 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 5 Aug 2013 21:41:12 -0400 From: Fam Zheng Date: Tue, 6 Aug 2013 09:40:34 +0800 Message-Id: <1375753243-19530-2-git-send-email-famz@redhat.com> In-Reply-To: <1375753243-19530-1-git-send-email-famz@redhat.com> References: <1375753243-19530-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v3 01/10] vmdk: Make VMDK3Header QEMU_PACKED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pmatouse@redhat.com, jcody@redhat.com, armbru@redhat.com, stefanha@redhat.com, famz@redhat.com, asias@redhat.com, areis@redhat.com Although the fields are all uint32_t, it's best to make it consistent that all on disk structures are QEMU_PACKED. Signed-off-by: Fam Zheng --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index 3756333..8ff43b9 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -62,7 +62,7 @@ typedef struct { uint32_t cylinders; uint32_t heads; uint32_t sectors_per_track; -} VMDK3Header; +} QEMU_PACKED VMDK3Header; typedef struct { uint32_t version; -- 1.8.3.4